Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump lock file for 7.17 #16412

Merged
merged 6 commits into from
Sep 3, 2024
Merged

bump lock file for 7.17 #16412

merged 6 commits into from
Sep 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2024

No description provided.

andsel
andsel reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the strscan notice notice text

tools/dependencies-report/src/main/resources/notices/strscan-NOTICE.txt Outdated
@@ -0,0 +1,56 @@
StringScanner is copyrighted free software by Minero Aoki.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems little bit different from https://github.com/elastic/logstash/blob/main/tools/dependencies-report/src/main/resources/notices/strscan-NOTICE.txt

@andsel andsel self-requested a review September 3, 2024 16:03
andsel
andsel approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green

@kaisecheng
Copy link
Contributor

CI red due to rexml change the param type from string to Regexp

Failures:
  |  
  | 1) Proxy support when `http_proxy` and `https_proxy` are configured when the $HOME/.m2/settings.xml doesn't exist defines the proxies in the xml file
  | Failure/Error: content = REXML::Document.new(File.read(settings))
  |  
  | REXML::ParseException:
  | #<TypeError: wrong argument type String (expected Regexp)>
  | org/jruby/ext/strscan/RubyStringScanner.java:258:in `scan'
  | org/jruby/ext/strscan/RubyStringScanner.java:307:in `scan'
  ...

@kaisecheng
Copy link
Contributor

upstream fixed it in 3.3.0 but not backport to 3.2.x ruby/rexml#142

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

mashhurs
mashhurs approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaisecheng kaisecheng merged commit 3e07c3a into 7.17 Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

@mashhurs mashhurs mashhurs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaisecheng @elasticmachine @andsel @mashhurs @jsvd @logstashmachine