Fix: delegating from deprecated setting #13481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this has only been a concern for settings such as Boolean
yaauie
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
This appears to fix the issue 👍🏼
It's not clear to me why I needed to route through wrapped.value, or if it was an explicit attempt to invoke the canonical proxy setting's validate function (which is protected, but should be the same as the wrapped setting's validate since they are clones of each other.
Good catch, though.
kares
added a commit
to kares/logstash
that referenced
this pull request
Dec 8, 2021
(cherry picked from commit 32b8739)
5 tasks
kares
added a commit
to kares/logstash
that referenced
this pull request
Dec 8, 2021
(cherry picked from commit 32b8739)
5 tasks
kares
added a commit
that referenced
this pull request
Dec 8, 2021
kares
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Fix Logstash unable to start when using deprecated setting
http.enabledWhat does this PR do?
Fixes a regression introduced in #13308 when setting
http.enabled.Why is it important/What is the impact to the user?
Users can rename the setting (
api.enabled) and not use the deprecated one, however need to be aware and this impacts the expectation for a smooth upgrade process in 7.xChecklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
Related issues