Fix: patch Puma around a JRuby ARM64 bug #13447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 d03426a (AARCH64) 🟢 d03426a (AMD64) had 1 unrelated intermittent failure with ubi8 |
kares
changed the title
|
the issue is present and surfaces on centos base image (not just the ubuntu 20:04 as detected initially) 🔴 f38f797 (AARCH64) 🟢 f38f797 (AMD64) except 1 intermittent failure with oss |
This reverts commit f38f797.
jsvd
reviewed
Nov 25, 2021
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
kares
added a commit
to kares/logstash
that referenced
this pull request
Nov 25, 2021
Co-authored-by: João Duarte <jsvd@users.noreply.github.com> (cherry picked from commit 32690cb)
1 task
kares
added a commit
to kares/logstash
that referenced
this pull request
Nov 25, 2021
Co-authored-by: João Duarte <jsvd@users.noreply.github.com> (cherry picked from commit 32690cb)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we're emulating the fallback logic just like it would happen on JRuby < 9.2.18.0.
The only consequence with the dummy
closed_socket?implementation seems to be stopping a request early.Please note that the
closed_socket?implementation was slightly different on Puma 4.x, however under JRuby, 4.x always uses the dummy fallback due theRUBY_PLATFORM =~ /linux/check (RUBY_PLATFORMreturns"java"on JRuby).Release notes
[rn:skip]
What does this PR do?
Patches around an upstream (JNR) bug which surfaces under ARM64.
Why is it important/What is the impact to the user?
Usable AARCH64 support (under Docker).
Author's Checklist
Related issues
500 Internal Server Erroron aarch64 linux nodes #13444 (this PR resolves the issue with a work-around)