Fixes a usage of deprecated 'http.enabled' to the new 'api.enabled' #13380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
previously requested changes
Nov 5, 2021
x-pack/spec/monitoring/inputs/metrics/stats_event_factory_spec.rb
Outdated
Show resolved
Hide resolved
andsel
force-pushed
the
fix/missed_api_enabled_renames
branch
from
15e1a92
to
a440731
Compare
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
andsel
force-pushed
the
fix/missed_api_enabled_renames
branch
from
a440731
to
e78f19d
Compare
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Nov 15, 2021
…lastic#13380) With elastic#13308 configuration namespace that started with `http.` was renamed to `api.`, this commit fix a usage left behind. Use the new `api.enabled` setting in one place instead of the deprecated `http.enable`. Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com> (cherry picked from commit 88c80eb)
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Nov 15, 2021
…lastic#13380) With elastic#13308 configuration namespace that started with `http.` was renamed to `api.`, this commit fix a usage left behind. Use the new `api.enabled` setting in one place instead of the deprecated `http.enable`. Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com> (cherry picked from commit 88c80eb)
andsel
added a commit
that referenced
this pull request
Nov 16, 2021
…api.enabled' (#13380) (#13407) With #13308 configuration namespace that started with `http.` was renamed to `api.`, this commit fix a usage left behind. Use the new `api.enabled` setting in one place instead of the deprecated `http.enable`. Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com> (cherry picked from commit 88c80eb)
andsel
added a commit
that referenced
this pull request
Nov 16, 2021
… 'api.enabled' (#13380) (#13408) With #13308 configuration namespace that started with `http.` was renamed to `api.`, this commit fix a usage left behind. Use the new `api.enabled` setting in one place instead of the deprecated `http.enable`. Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com> (cherry picked from commit 88c80eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
With #13308 configuration namespace that started with
http.was renamed toapi., this commit fix a usage left behind.Use the new
api.enabledsetting in one place instead of the deprecatedhttp.enable.Why is it important/What is the impact to the user?
Avoid polluting Logstash logs with warning messages like:
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs