[Maps][Vega] Isolate mapbox-gl library into bazel package #99931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
commented
May 12, 2021
thomasneirynck
added
chore
[Deprecated-Use Team:Presentation]Team:Geo
mistic
reviewed
May 24, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
added
the
release_note:skip
thomasneirynck
changed the title
stratoula
approved these changes
May 25, 2021
nreese
approved these changes
May 25, 2021
| @@ -2678,6 +2678,10 @@ | |||
| version "0.0.0" | |||
| uid "" | |||
|
|
|||
| "@kbn/mapbox-gl@link:bazel-bin/packages/kbn-mapbox-gl/npm_module": | |||
| version "0.0.0" | |||
There was a problem hiding this comment.
Why is version 0.0.0 here but 1.0.0 in kbn/mapbox-gl?
There was a problem hiding this comment.
I don't know. It seems to be pretty consistent, also for other bazel-ackages in the yarn-lock.
cc @mistic do you know why this version is 0.0.0?
miukimiu
approved these changes
May 25, 2021
thomasneirynck
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 25, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 25, 2021
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves mapboxgl library instantiation in separate bazel package.
It is shared by Maps and Vega. Apart from removing duplication, this also avoids duplicate initialization of the workerUrl and RTL-plugin if user both loads Maps and Vega during the same session.
[EDIT]
Discussed offline with @nreese. A follow-on PR will isolate the type-exports in this same package.