Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] use deep equals for mapbox filter expression equals check #99673

Merged
merged 2 commits into from
May 11, 2021
Merged

[Maps] use deep equals for mapbox filter expression equals check #99673

merged 2 commits into from
May 11, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 10, 2021

Fixes #53246

This PR isolates the mapbox filter expression refactor from closed #96791.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels May 10, 2021
@nreese nreese requested a review from a team as a code owner May 10, 2021 18:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB -268.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx discuss offline, this really helps readability. it will also help with client-side masking for timeslider when that gets added.

@nreese nreese merged commit 5dbc73f into elastic:master May 11, 2021
nreese added a commit to nreese/kibana that referenced this pull request May 11, 2021
@nreese
[Maps] use deep equals for mapbox filter expression equals check (ela…
0134ff8 
…stic#99673)

* [Maps] use deep equals for mapbox filter expression equals check

* cleanup
@nreese nreese mentioned this pull request May 11, 2021
Merged
nreese added a commit that referenced this pull request May 11, 2021
@nreese
[Maps] use deep equals for mapbox filter expression equals check (#99673
838ea20 
) (#99803)

* [Maps] use deep equals for mapbox filter expression equals check

* cleanup
@nreese nreese mentioned this pull request Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] change equals check for mapbox filter expressions
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck