-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exploratory View] Mobile experience #99565
Merged
Merged
Changes from 5 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
5461cf8
wip
shahzad31 195ad59
Merge branch 'master' into mobile-experience
shahzad31 9e261b8
Merge branch 'master' into mobile-experience
shahzad31 9626988
wip
shahzad31 850f555
Merge branch 'master' into mobile-experience
kibanamachine b522c08
Merge branch 'master' into mobile-experience
shahzad31 720c68f
update
shahzad31 e8a678f
updated agent filter name to 'iOS/swift'
bryce-b 5a260b2
Merge pull request #4 from bryce-b/mobile-experience
shahzad31 e2a6e1b
Merge branch 'master' into mobile-experience
shahzad31 32d36c2
Merge branch 'mobile-experience' of https://github.com/shahzad31/kiba…
shahzad31 9884d27
update memory and cpu
shahzad31 487e9c4
fix
shahzad31 24768ea
Merge branch 'master' into mobile-experience
kibanamachine 41a76f3
Merge branch 'master' into mobile-experience
shahzad31 9ea07ec
Merge branch 'master' into mobile-experience
shahzad31 f71aa48
fix types
shahzad31 dde04c3
Merge branch 'mobile-experience' of https://github.com/shahzad31/kiba…
shahzad31 2cb4f1a
fix type and filters
shahzad31 51569fa
Merge branch 'master' into mobile-experience
shahzad31 e54969c
fix image
shahzad31 1631c07
Merge branch 'master' into mobile-experience
shahzad31 1f9c6ad
added mobile experience
shahzad31 17786ca
Merge branch 'master' into mobile-experience
shahzad31 9421c50
resolve conflicts
shahzad31 5192aa0
refactor code for has data
shahzad31 716184f
added throughput and distribution configs for mobile data
AlexanderWert 6a1390d
Merge pull request #5 from AlexanderWert/mobile-exploratory-view
shahzad31 3a8bb82
Merge branch 'master' into mobile-experience
shahzad31 48ece1f
update
shahzad31 26de779
Merge branch 'master' into mobile-experience
shahzad31 6754f80
fix types
shahzad31 541df52
Merge branch 'master' into mobile-experience
shahzad31 fe641a0
added environment
shahzad31 423fba9
fix test
shahzad31 a802015
fix type
shahzad31 dfc1690
use i18n
shahzad31 8ab2ddd
Merge branch 'master' into mobile-experience
shahzad31 7f3bbc3
fix i18n
shahzad31 b1005cd
Added mobile device distribution config + fixed mobile field names
AlexanderWert c949862
fixing chart type options and label for distribution
AlexanderWert ec009fb
Merge pull request #6 from AlexanderWert/mobile-exploratory-view
shahzad31 2a9e540
Merge branch 'master' into mobile-experience
shahzad31 22ef586
fix types
shahzad31 ebf4ec5
fix 18n
shahzad31 0ecb538
fix test
shahzad31 2289c58
fix lint
shahzad31 067a7c3
Merge branch 'master' into mobile-experience
shahzad31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
...blic/components/shared/exploratory_view/configurations/mobile/response_duration_config.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { ConfigProps, DataSeries } from '../../types'; | ||
import { FieldLabels } from '../constants'; | ||
import { buildPhraseFilter } from '../utils'; | ||
import { SERVICE_NAME, TRANSACTION_DURATION } from '../constants/elasticsearch_fieldnames'; | ||
|
||
export function getResponseDurationLensConfig({ seriesId, indexPattern }: ConfigProps): DataSeries { | ||
return { | ||
id: seriesId, | ||
reportType: 'service-latency', | ||
defaultSeriesType: 'line', | ||
seriesTypes: ['line', 'bar'], | ||
xAxisColumn: { | ||
sourceField: '@timestamp', | ||
}, | ||
yAxisColumns: [ | ||
{ | ||
operationType: 'average', | ||
sourceField: 'transaction.duration.us', | ||
label: 'Latency', | ||
}, | ||
], | ||
hasOperationType: true, | ||
defaultFilters: [ | ||
'labels.net_connection_carrier_name', | ||
'labels.device_model', | ||
'labels.net_connection_type', | ||
'host.os.platform', | ||
'host.os.full', | ||
], | ||
breakdowns: [ | ||
'labels.net_connection_carrier_name', | ||
'labels.device_model', | ||
'labels.net_connection_type', | ||
'host.os.platform', | ||
'labels.net_connection_carrier_isoCountryCode', | ||
], | ||
filters: [ | ||
...buildPhraseFilter('transaction.type', 'request', indexPattern), | ||
shahzad31 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
...buildPhraseFilter('agent.name', 'opentelemetry/swift', indexPattern), | ||
], | ||
labels: { | ||
...FieldLabels, | ||
[TRANSACTION_DURATION]: 'Response time', | ||
[SERVICE_NAME]: 'Mobile app', | ||
}, | ||
reportDefinitions: [ | ||
{ | ||
field: 'service.name', | ||
required: true, | ||
}, | ||
], | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a little odd to return the indices from this endpoint, since it's called
has_data
. If we really want to do it, shouldn't this include all of the indices that are being queried?Eg:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally i think we should return info like this from all endpoints. I will modify it to return whole APM indices settings, instead of just transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should every API return this info? We already have an API (
GET /api/apm/settings/apm-index-settings
) where you can get this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i meant in a sense of visiblity perspective, the way we are doing that inspect stuff for debugging purpose, i think it's no harm if we return indices information as an API response, it instanlty give you a view, against which indices that API got executed.