-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Provide guidance of "Custom" allocation behavior in ILM (#96111) #99004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide allocation behavior guidance when the user has selected Custom, but no attributes are available and: ...data nodes are in use, so indices will allocate to data nodes. ...data tiers are available, so indices will allocate to data tiers. ...data tiers are available but not for the given phase's tier, so indices will be allocated to a fallback data tier. ...no data tiers are available, so allocation won't occur. * Provide link to the migration docs. * Adjust copy to consistently notify the user that node attributes are missing and guide them to use role-based allocation. * Localize disableDataTierOption flag instead of passing it as a prop, to make it easier to reason about. * Clarify the scenario in which the user has selected node_attrs allocation but no data tiers are available. * Remove inapplicable frozen tier from NoTiersAvailableNotice. * Refactor and update tests. * Split up node allocation tests to improve discoverability. Refactor test helpers to define suite-specific helper interfaces, to improve maintainability. * Refactor tests to make the [using node attributes, using node roles] branch and the various conditions within easier to contrast and compare. * Add coverage for NoTiersAvailableUsingNodeAttributesNotice scenario. * Add some helpers for improved maintainability and readability. * Create helpers/types file to store extracted Phase type.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Search Sessions Integration.x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time·ts.Dashboard save a search sessions with relative time "after all" hook for "Saves and restores a session with relative time ranges"Standard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: