Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/analytics into bazel #98917

Merged
merged 9 commits into from
May 3, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Apr 30, 2021

One step forward on #69706

That PR moves the @kbn/analytics into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 30, 2021
@mistic

This comment has been minimized.

@mistic mistic marked this pull request as ready for review April 30, 2021 19:14
@mistic mistic requested review from a team as code owners April 30, 2021 19:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic

This comment has been minimized.

@mistic mistic requested a review from jbudz April 30, 2021 21:44
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks! I've pulled the changes and checked that the package is still working on the browser

@mistic

This comment has been minimized.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-js 6.7MB 6.7MB +352.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 4af6e9c into elastic:master May 3, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 98917

mistic added a commit to mistic/kibana that referenced this pull request May 3, 2021
* chore(NA): moving @kbn/analytics into bazel

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): separate type generating from server code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-analytics/scripts/build.js
mistic added a commit that referenced this pull request May 3, 2021
* chore(NA): moving @kbn/analytics into bazel

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): separate type generating from server code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-analytics/scripts/build.js
@mistic mistic mentioned this pull request May 4, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants