Fixes histogram plot disappears when time range is too small (issue #733) #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#733) This fixes rounding behaviour in interval_to_ms. The interval_to_ms function will round any fractional component of an interval to 0 because it tries to parse it as an integer. I've fixed it by trying by parsing as a float but then trying to preserve the existing behaviour of returning integer results in the callers. closes elasticsearch/kibana/elastic#733
|
This looks great, I'd love to get it merged. Can you make sure you've signed the CLA here https://github.com/elasticsearch/kibana/blob/master/CONTRIBUTING.md |
|
Done! Thanks. On Tuesday, February 25, 2014 at 1:39 AM, Rashid Khan wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rounding behaviour in interval_to_ms. The interval_to_ms
function will round any fractional component of an interval to 0 because
it tries to parse it as an integer.
I've fixed it by trying by parsing as a float but then trying to preserve
the existing behaviour of returning integer results in the callers.
closes elasticsearch/kibana/#733