Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Management] Agent picker follow up #97357

Merged
merged 8 commits into from
Apr 17, 2021
Merged

[Asset Management] Agent picker follow up #97357

merged 8 commits into from
Apr 17, 2021

Conversation

lykkin
Copy link
Contributor

@lykkin lykkin commented Apr 16, 2021 •
edited
Loading

Summary

host-picker-followup

Checklist

Delete any items that are not applicable to this PR.

@lykkin lykkin added v8.0.0 v7.13.0 Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature release_note:feature Makes this part of the condensed release notes labels Apr 16, 2021
@lykkin lykkin requested a review from a team as a code owner April 16, 2021 07:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@lykkin
Copy link
Contributor Author

lykkin commented Apr 16, 2021

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 17, 2021
@patrykkopycinski patrykkopycinski enabled auto-merge (squash) April 17, 2021 08:24
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 141 281 +140

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 769.7KB 905.7KB +136.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 11.1KB 11.2KB +68.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lykkin

@patrykkopycinski patrykkopycinski merged commit e0da8b2 into elastic:master Apr 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 17, 2021
@lykkin @kibanamachine
[Asset Management] Agent picker follow up (elastic#97357)
3d6d54d
@kibanamachine kibanamachine mentioned this pull request Apr 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 17, 2021
@kibanamachine @lykkin
[Asset Management] Agent picker follow up (#97357) (#97389)
b522c8c 
Co-authored-by: Bryan Clement <bclement01@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into watcher/migra…
87d64a4 
…te-legacy-es-client

* 'master' of github.com:elastic/kibana: (102 commits)
  [Exploratory view] integerate page views to exploratory view (elastic#97258)
  Fix typo in license_api_guard README name and import http server mocks from public interface (elastic#97334)
  Avoid mutating KQL query when validating it (elastic#97081)
  Add description as title on tag badge (elastic#97109)
  Remove legacy ES client usages in `home` and `xpack_legacy` (elastic#97359)
  [Fleet] Finer-grained error information from install/upgrade API (elastic#95649)
  Rule registry bundle size (elastic#97251)
  [Partial Results] Move other bucket into Search Source (elastic#96384)
  [Dashboard] Makes lens default editor for creating new panels (elastic#96181)
  skip flaky suite (elastic#97387)
  [Asset Management] Agent picker follow up (elastic#97357)
  skip flaky suite (elastic#97382)
  [Security Solutions] Fixes flake with cypress tests (elastic#97329)
  skip flaky suite (elastic#97355)
  Skip test to try and stabilize master
  minimize number of so fild asserted in tests. it creates flakines when implementation details change (elastic#97374)
  [Search Sessions] Client side search cache (elastic#92439)
  [SavedObjects] Add aggregations support (elastic#96292)
  [Reporting] Remove legacy elasticsearch client usage from the reporting plugin (elastic#97184)
  [kbnClient] fix basePath handling and export reponse type (elastic#97277)
  ...

# Conflicts:
#	x-pack/plugins/watcher/server/lib/license_pre_routing_factory/license_pre_routing_factory.ts
#	x-pack/plugins/watcher/server/plugin.ts
#	x-pack/plugins/watcher/server/routes/api/indices/register_get_route.ts
#	x-pack/plugins/watcher/server/routes/api/license/register_refresh_route.ts
#	x-pack/plugins/watcher/server/routes/api/register_list_fields_route.ts
#	x-pack/plugins/watcher/server/routes/api/register_load_history_route.ts
#	x-pack/plugins/watcher/server/routes/api/settings/register_load_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/action/register_acknowledge_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_activate_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_deactivate_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_delete_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_execute_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_history_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_load_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_save_route.ts
#	x-pack/plugins/watcher/server/routes/api/watch/register_visualize_route.ts
#	x-pack/plugins/watcher/server/routes/api/watches/register_delete_route.ts
#	x-pack/plugins/watcher/server/routes/api/watches/register_list_route.ts
#	x-pack/plugins/watcher/server/shared_imports.ts
#	x-pack/plugins/watcher/server/types.ts
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
@lykkin @madirey
[Asset Management] Agent picker follow up (elastic#97357)
f2a90af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@lykkin lykkin

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Osquery Security Solution Osquery feature release_note:feature Makes this part of the condensed release notes Team:Asset Management Security Asset Management Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lykkin @elasticmachine @kibanamachine @patrykkopycinski