Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: Fix color assertion with risk of percentage being rounded to 0. #95797

Merged
merged 16 commits into from
Apr 6, 2021
Merged

[ML] Data Frame Analytics: Fix color assertion with risk of percentage being rounded to 0. #95797

merged 16 commits into from
Apr 6, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 30, 2021 •
edited
Loading

Summary

Fixes #91450.

  • Fix color assertion with risk of percentage being rounded to 0.
  • Better naming of attributes of expected values.
  • Adds assertions to use the sample size dropdown and randomize query switch.

Checklist

@walterra walterra self-assigned this Mar 30, 2021
@walterra
Copy link
Contributor Author

walterra commented Apr 1, 2021 •
edited
Loading

1st run flaky test runner for xpack groups 3/9.

@walterra walterra marked this pull request as ready for review April 1, 2021 12:49
@walterra walterra requested a review from a team as a code owner April 1, 2021 12:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra added the release_note:skip Skip the PR/issue when compiling release notes label Apr 1, 2021
pheyos
pheyos approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@qn895
Copy link
Member

qn895 commented Apr 5, 2021

LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +114.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra
Copy link
Contributor Author

walterra commented Apr 6, 2021

2nd run flaky test runner for xpack groups 3/9.

🥳

peteharverson
peteharverson approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit d9a4752 into elastic:master Apr 6, 2021
@walterra walterra deleted the ml-fix-canvas-element-2 branch April 6, 2021 13:21
@walterra walterra mentioned this pull request Apr 6, 2021
Merged
walterra added a commit to walterra/kibana that referenced this pull request Apr 6, 2021
@walterra
[ML] Data Frame Analytics: Fix color assertion with risk of percentag…
b041877 
…e being rounded to 0. (elastic#95797)

- Fix color assertion with risk of percentage being rounded to 0.
- Better naming of attributes of expected values.
- Adds assertions to use the sample size dropdown and randomize query switch.
walterra added a commit to walterra/kibana that referenced this pull request Apr 6, 2021
@walterra
[ML] Data Frame Analytics: Fix color assertion with risk of percentag…
ae407f8 
…e being rounded to 0. (elastic#95797)

- Fix color assertion with risk of percentage being rounded to 0.
- Better naming of attributes of expected values.
- Adds assertions to use the sample size dropdown and randomize query switch.
@walterra walterra mentioned this pull request Apr 6, 2021
Merged
walterra added a commit that referenced this pull request Apr 6, 2021
@walterra
[ML] Data Frame Analytics: Fix color assertion with risk of percentag…
fc2b936 
…e being rounded to 0. (#95797) (#96306)

- Fix color assertion with risk of percentage being rounded to 0.
- Better naming of attributes of expected values.
- Adds assertions to use the sample size dropdown and randomize query switch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@walterra walterra

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@walterra @elasticmachine @qn895 @kibanamachine @pheyos @peteharverson