Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest pipelines] Prepare processors editor for EUI v8 (Amsterdam theme) #95310

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Mar 24, 2021

Summary

Current master

With the EUI v7 theme, the Ingest pipeline editor looks like:

Screenshot 2021-03-24 at 14 48 42

The top-level panels have a shadow applied to create a bit of depth with panels nested inside of other panels having no shadow to give a flat appearance.

On the new Amsterdam light theme the ingest pipelines editor looks like:

Screenshot 2021-03-24 at 15 25 28

Because the default is for panels to be borderless, the nested panel looks indistinct from the containing panel. Additionally, the box shadow has a larger area which creates a dark gradient that gets cut off sharply. The bottom of the editor is where this is most pronounced:

Screenshot 2021-03-24 at 15 25 39

After these changes

To make the editor look good in both v7 and v8 we can remove shadows at all levels (i.e., make the entire tree flat) and add borders on nested panel items (or all panel items). Pending the ability to set hasBorder on #93796. Setting hasShadow={false} creates the following visual appearance:

v7:

Screenshot 2021-03-30 at 14 10 54

v8:

Screenshot 2021-03-30 at 14 01 17

@jloleysens jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management v7.13.0 labels Mar 24, 2021
@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens jloleysens marked this pull request as ready for review March 30, 2021 12:13
@jloleysens jloleysens requested review from a team as code owners March 30, 2021 12:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens jloleysens requested a review from mdefazio March 30, 2021 12:13
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 672.7KB 672.3KB -394.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@jloleysens jloleysens merged commit 97c9610 into elastic:master Mar 31, 2021
@jloleysens jloleysens deleted the ingest-pipelines/prepare-for-eui-v8-theme branch March 31, 2021 08:06
jloleysens added a commit that referenced this pull request Mar 31, 2021
…eme) (#95310) (#95889)

* remove shadows from eui panel at all levels

* added "hasBorder" to support nested panels

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants