-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest] switch to jest-environment-jsdom #95125
[jest] switch to jest-environment-jsdom #95125
Conversation
@elasticmachine merge upstream |
Bunch of test timouts in the first CI run https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/114461/testReport/ |
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
These global_search failures seem like something, no? That test is explicitly testing which element is the active focus element and the results are now different when using the other jsdom. Seems potentially problematic for any a11y related tests in the future. |
I imagine it's possible that newer versions of JSDOM support a different amount of a11y interactions, maybe more or less, but I'm not sure and that's why those tests have been pinned to JSDOM 13. I think it's up to people who understand the test better to figure out if they can or should upgrade to a more modern version of JSDOM. I expect that JSDOM better emulates browsers in more modern versions, so maybe it's an actual issue with the component that the tests weren't able to test for before, or maybe there were special accommodations added for the way JSDOM 13 worked... Could be a lot of things I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for opening team-specific issues
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
In #58095 we switched to the
jest-environment-jsdom-thirteen
package because at the time Jest was stuck on version 11 of JSDOM, they have since upgraded their version and we can now switch back over to the standardjest-environment-jsdom
package which includes several other new features (like the "modern" timer mocks).