Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix filter creation for numeric scripted fields in Discover #93224

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 2, 2021

Summary

Resolves #74301

Release Note

Fixes filter creation for numeric scripted fields in Discover.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 v7.12.0 SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week labels Mar 2, 2021
@lizozom lizozom requested a review from a team as a code owner March 2, 2021 14:17
@lizozom lizozom self-assigned this Mar 2, 2021
@lizozom lizozom changed the title Bug 74301 [Bug] Fix filter creation for numeric scripted fields in Discover Mar 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 915.9KB 915.9KB +72.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, changes look good to me

@lizozom lizozom merged commit 6ee568c into elastic:master Mar 3, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2021
* master: (45 commits)
  Add outcome of node scripts/build_api_docs (elastic#93399)
  [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279)
  [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224)
  [uptime] Fix anomaly alert edit (elastic#93025)
  Consolidate @babel/* packages and use latest compatible version (elastic#93264)
  [Search Embeddable] Add highlighting when searching (elastic#93178)
  [APM] Add missing bottom border to header (elastic#93179)
  [CI] No longer collect APM span stack traces (elastic#93263)
  [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024)
  update generated public api docs
  API DOCS Step 3/3 (elastic#92929)
  chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262)
  rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620)
  [kbn/optimizer] allow customizing the limits path from the script (elastic#93153)
  [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830)
  [jenkins] convert baseline capture job to use tasks (elastic#93288)
  removing the linked issue in comments from PR (elastic#93303)
  chore(NA): do not include fs within a storybook build (elastic#93294)
  [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156)
  Add searchDuration to EQL and Threshold rules (elastic#93149)
  ...
lizozom added a commit to lizozom/kibana that referenced this pull request Mar 3, 2021
lizozom added a commit to lizozom/kibana that referenced this pull request Mar 3, 2021
lizozom added a commit that referenced this pull request Mar 3, 2021
lizozom added a commit that referenced this pull request Mar 3, 2021
@timroes timroes added the Feature:Discover Discover Application label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application release_note:fix SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter panel is not handling scripted fields of type number
4 participants