[Actions][Docs] Moving subaction and subaction params back to README #92878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
added
Feature:Actions
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
1 task
|
@elasticmachine merge upstream |
gchaps
reviewed
Mar 1, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…ns/readme-again
…into actions/readme-again
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
…lastic#92878) * Moving subaction and subaction params back to README * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
…lastic#92878) * Moving subaction and subaction params back to README * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 2, 2021
…92878) (#93281) * Moving subaction and subaction params back to README * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 2, 2021
…92878) (#93283) * Moving subaction and subaction params back to README * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * PR fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #91789, I moved all the action type params to the user docs. However, for the ServiceNow, Jira and IBM Reslient actions, the details of subaction type and subaction params are not visible at a user level so they shouldn't be in the user docs. This PR moves the subaction types and params back to the README and reverts to user docs to just showing the fields a user can fill out.
Checklist