Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ui counters flaky test #91372

Merged
merged 2 commits into from
Feb 15, 2021
Merged

fix ui counters flaky test #91372

merged 2 commits into from
Feb 15, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Feb 15, 2021

  • Use savedObjects api to fetch uiCounter type
  • Refactor testing code

Closes #85086

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 15, 2021
@Bamieh
Copy link
Member Author

Bamieh commented Feb 15, 2021

@elasticmachine merge upstream

@Bamieh Bamieh requested a review from afharo February 15, 2021 12:51
afharo
afharo approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's hope this definitely fixes the Flaky tests and all CI are green :)

Thanks for doing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 643794e into elastic:master Feb 15, 2021
@Bamieh Bamieh deleted the telemetry/fix_flaky_test branch February 15, 2021 17:06
@Bamieh Bamieh mentioned this pull request Feb 15, 2021
Merged
Bamieh added a commit that referenced this pull request Feb 15, 2021
@Bamieh
[7.x] fix ui counters flaky test (#91372) (#91433)
004b1df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@Bamieh @kibanamachine @afharo