Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Darker shade for Error group details labels #91349

Merged

Conversation

jim-fung
Copy link

Closes #90927

Summary

Issue 90927 was solved by changing the EUI value that is used in the header for an Error occurrence detail from theme.eui.euiColorMediumShade to theme.eui.euiColorDarkShade, thereby making it WCAG compliant.

Amount of axe accessibility issues were reduced from 13 to 11
axe_after
axe_before

Darkmode before/after
dark_before
dark_after

Lightmode before/after
light_before
light_after

Checklist

@jim-fung jim-fung requested a review from a team as a code owner February 14, 2021 16:03
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 14, 2021
@kibanamachine kibanamachine added 💝community and removed Team:APM All issues that need APM UI Team support labels Feb 14, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Feb 14, 2021

💚 CLA has been signed

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar
Copy link
Member

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 14, 2021
@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 and removed Team:APM All issues that need APM UI Team support labels Feb 14, 2021
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 15, 2021
@sorenlouv
Copy link
Member

@amtmolecule Thanks for the contribution!

@sorenlouv
Copy link
Member

retest

@dgieselaar dgieselaar added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB -2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 5c820cc into elastic:master Feb 15, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 15, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","auto-backport","release_note:skip","v7.12.0","💝community"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"5c820cc95f0ba3e6e2eb0f7461860f1dc78f87b7\",\"formattedMessage\":\"[APM] Darker shade for Error group details labels (#91349)\",\"originalMessage\":\"[APM] Darker shade for Error group details labels (#91349)\\n\\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\",\"pullNumber\":91349,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] [APM] Darker shade for Error group details labels (#91349)\". kibanamachine:backport/7.x/pr-91349 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1128ms"}
{"level":"info","message":"Adding assignees to #91393: amtmolecule"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91393/assignees - 201 in 447ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91393/labels - 200 in 387ms"}
View pull request: https://github.com/elastic/kibana/pull/91393

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 15, 2021
…ndition-for-hiding-recommded-allocation

* 'master' of github.com:elastic/kibana:
  [Discover] Fix toggling multi fields from doc view table (elastic#91121)
  [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991)
  skip flaky suite (elastic#86948)
  skip flaky suite (elastic#91191)
  Fix date histogram time zone for rollup index (elastic#90632)
  [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837)
  [Logs UI] Use useMlHref hook for ML links (elastic#90935)
  Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428)
  [APM] Darker shade for Error group details labels (elastic#91349)
  [Lens] Adjust new copy for 7.12 (elastic#90413)
  [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280)
  [Lens] Fix empty display name issue in XY chart (elastic#91132)
  [Lens] Improves error messages when in Dashboard (elastic#90668)
  [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546)
  [Lens] Improves ranking feature in Top values (elastic#90749)
  [ILM] Rollover min age tooltip and copy fixes (elastic#91110)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed 💝community release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Labels in the Error occurrence detail header are not using EUI color variable
5 participants