Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs #90713

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Feb 9, 2021

Summary

Resolves #89321

Converts the following plugins to TS project references:

  • rollup
  • remote_clusters
  • index_lifecycle_management
  • cross_cluster_replication

Partial stats from running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit:

Before:
Files: 11252
Lines: 1246802

After:
Files: 10564
Lines: 1213000

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 9, 2021
@TinaHeiligers TinaHeiligers changed the title Converts rollup to a TS project ref TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs Feb 9, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review February 9, 2021 14:10
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner February 9, 2021 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TinaHeiligers , thanks a lot for migrating those plugins!
changes LGTM! 👍

@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 9, 2021
@TinaHeiligers TinaHeiligers enabled auto-merge (squash) February 9, 2021 17:16
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:Elasticsearch UI","auto-backport","chore","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"6dde543b6c6a34fa025a6d6a8f0f5a7bb7d78a95\",\"formattedMessage\":\"TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs (#90713)\",\"originalMessage\":\"TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs (#90713)\\n\\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\",\"pullNumber\":90713,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] TS project refs: Converts rollup, remoteClusters, crossClusterReplication, indexLifecycleManagement to a TS project refs (#90713)\". kibanamachine:backport/7.x/pr-90713 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1088ms"}
{"level":"info","message":"Adding assignees to #90837: TinaHeiligers"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/90837/assignees - 201 in 511ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/90837/labels - 200 in 361ms"}
View pull request: https://github.com/elastic/kibana/pull/90837

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2021
…tion, indexLifecycleManagement to a TS project refs (elastic#90713)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
TinaHeiligers added a commit that referenced this pull request Feb 9, 2021
…eplication, indexLifecycleManagement to a TS project refs (#90713) (#90837)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
@TinaHeiligers TinaHeiligers deleted the ts-project-refs/rollup_remoteclusters_ccr_ILM branch March 23, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins
4 participants