Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM-UI][E2E] use githubNotify step #90514

Merged
merged 2 commits into from
Feb 8, 2021
Merged

[APM-UI][E2E] use githubNotify step #90514

merged 2 commits into from
Feb 8, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 5, 2021

Summary

Use the githubNotify step instead the wrapper.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@v1v v1v self-assigned this Feb 5, 2021
@v1v v1v added apm Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes labels Feb 5, 2021
@v1v v1v added the v7.12.0 label Feb 8, 2021
@v1v
Copy link
Member Author

v1v commented Feb 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@v1v v1v merged commit d201ed7 into elastic:master Feb 8, 2021
This was referenced Feb 8, 2021
Closed
Closed
v1v added a commit to v1v/kibana that referenced this pull request Feb 8, 2021
@v1v
[APM-UI][E2E] use githubNotify step (elastic#90514)
1877457
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 8, 2021
@gmmorris
Merge branch 'master' into task-manager/support-limited-concurrency
e3c8430 
* master: (55 commits)
  [APM-UI][E2E] use githubNotify step (elastic#90514)
  [APM] Export ProcessorEvent type (elastic#90540)
  [Lens] Retain column config (elastic#90048)
  [Data Table] Add unit tests (elastic#90173)
  Migrate most plugins to synchronous lifecycle (elastic#89562)
  skip flaky suite (elastic#90555)
  skip flaky suite (elastic#64473)
  [actions] improve email action doc (elastic#90020)
  [Fleet] Support Fleet server system indices (elastic#89372)
  skip flaky suite (elastic#90552)
  Bump immer dependencies (elastic#90267)
  Unrevert "Migrations v2: don't auto-create indices + FTR/esArchiver support (elastic#85778)" (elastic#89992)
  [Search Sessions] Use sync config (elastic#90138)
  chore(NA): add safe guard to remove bazelisk from yarn global at bootstrap (elastic#90538)
  [test] Await retry.waitFor (elastic#90456)
  chore(NA): integrate build buddy with our bazel setup and remote cache for ci (elastic#90116)
  Skip failing suite (elastic#90526)
  [Fleet] Fix incorrect conversion of string to numeric values in agent YAML (elastic#90371)
  [Docs] Update reporting troubleshooting for arm rhel/centos (elastic#90385)
  chore(NA): build bazel projects all at once in the distributable build process (elastic#90328)
  ...
v1v added a commit to v1v/kibana that referenced this pull request Feb 8, 2021
@v1v
Revert "[APM-UI][E2E] use githubNotify step (elastic#90514)"
1b9bf59 
This reverts commit d201ed7.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 10, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 90514 or prevent reminders by adding the backport:skip label.

@v1v v1v removed backport missing Added to PRs automatically when the are determined to be missing a backport. v7.12.0 v8.0.0 labels Feb 17, 2021
@v1v v1v deleted the feature/use-notify branch February 17, 2021 14:33
@v1v v1v added the backport:skip This commit does not require backporting label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
apm backport:skip This commit does not require backporting Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @kibanamachine @cachedout @mdelapenya @kuisathaverat