Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove UI filters from UI (#89793) #90321

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 4, 2021

Backports the following commits to 7.x:

* Start moving some stuff

* Move some stuff around

* more

* Transactions label

* some snake casing

* i18n fix

* Remove unused ui filters endpoints

* Updates to select

* remove projections

* Use urlHelpers.push

* License change
@smith smith added the backport label Feb 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alerts - 24 +24
apm - 1736 +1736
beatsManagement - 302 +302
canvas - 1158 +1158
cloud - 7 +7
crossClusterReplication - 161 +161
dashboardEnhanced - 34 +34
dashboardMode - 4 +4
dataEnhanced - 95 +95
discoverEnhanced - 10 +10
embeddableEnhanced - 11 +11
enterpriseSearch - 1189 +1189
features - 11 +11
fleet - 458 +458
globalSearch - 24 +24
globalSearchBar - 38 +38
globalSearchProviders - 8 +8
graph - 173 +173
grokdebugger - 75 +75
indexLifecycleManagement - 177 +177
indexManagement - 528 +528
infra - 1047 +1047
ingestPipelines - 492 +492
lens - 478 +478
licenseManagement - 145 +145
licensing - 12 +12
lists - 130 +130
logstash - 54 +54
maps - 689 +689
mapsFileUpload - 187 +187
mapsLegacyLicensing - 4 +4
ml - 1739 +1739
monitoring - 619 +619
observability - 109 +109
osquery - 49 +49
painlessLab - 35 +35
remoteClusters - 141 +141
reporting - 51 +51
rollup - 179 +179
runtimeFields - 18 +18
savedObjectsTagging - 99 +99
searchprofiler - 89 +89
security - 475 +475
securitySolution - 2179 +2179
snapshotRestore - 178 +178
spaces - 236 +236
stackAlerts - 51 +51
transform - 213 +213
triggersActionsUi - 337 +337
uiActionsEnhanced - 120 +120
upgradeAssistant - 120 +120
uptime - 581 +581
urlDrilldown - 29 +29
watcher - 237 +237
total +17345

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm - 5.2MB ⚠️ +5.2MB
beatsManagement - 537.6KB ⚠️ +537.6KB
canvas - 1.4MB ⚠️ +1.4MB
crossClusterReplication - 318.1KB ⚠️ +318.1KB
dataEnhanced - 147.7KB +147.7KB
enterpriseSearch - 1.8MB ⚠️ +1.8MB
fleet - 752.1KB ⚠️ +752.1KB
graph - 1.2MB ⚠️ +1.2MB
grokdebugger - 555.0KB ⚠️ +555.0KB
indexLifecycleManagement - 231.9KB ⚠️ +231.9KB
indexManagement - 1.4MB ⚠️ +1.4MB
infra - 1.9MB ⚠️ +1.9MB
ingestPipelines - 723.3KB ⚠️ +723.3KB
lens - 874.9KB ⚠️ +874.9KB
licenseManagement - 134.7KB +134.7KB
logstash - 48.8KB +48.8KB
maps - 2.6MB ⚠️ +2.6MB
mapsFileUpload - 825.8KB ⚠️ +825.8KB
ml - 6.6MB ⚠️ +6.6MB
monitoring - 795.7KB ⚠️ +795.7KB
observability - 187.7KB +187.7KB
osquery - 95.7KB +95.7KB
painlessLab - 29.4KB +29.4KB
remoteClusters - 175.9KB +175.9KB
reporting - 34.8KB +34.8KB
rollup - 245.4KB ⚠️ +245.4KB
savedObjectsTagging - 82.9KB +82.9KB
searchprofiler - 670.2KB ⚠️ +670.2KB
security - 724.4KB ⚠️ +724.4KB
securitySolution - 7.5MB ⚠️ +7.5MB
snapshotRestore - 482.6KB ⚠️ +482.6KB
spaces - 41.2KB +41.2KB
stackAlerts - 681.5KB ⚠️ +681.5KB
transform - 915.6KB ⚠️ +915.6KB
triggersActionsUi - 1.4MB ⚠️ +1.4MB
upgradeAssistant - 140.7KB +140.7KB
uptime - 895.8KB ⚠️ +895.8KB
watcher - 887.7KB ⚠️ +887.7KB
total ⚠️ +43.0MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerts - 65.4KB +65.4KB
apm - 22.9KB +22.9KB
beatsManagement - 126.4KB +126.4KB
canvas - 587.3KB ⚠️ +587.3KB
cloud - 5.2KB +5.2KB
crossClusterReplication - 37.0KB +37.0KB
dashboardEnhanced - 24.0KB +24.0KB
dashboardMode - 4.9KB +4.9KB
dataEnhanced - 36.1KB +36.1KB
discoverEnhanced - 10.3KB +10.3KB
embeddableEnhanced - 11.4KB +11.4KB
enterpriseSearch - 15.4KB +15.4KB
features - 7.3KB +7.3KB
fleet - 365.9KB ⚠️ +365.9KB
globalSearch - 15.8KB +15.8KB
globalSearchBar - 48.5KB +48.5KB
globalSearchProviders - 8.9KB +8.9KB
graph - 11.7KB +11.7KB
grokdebugger - 8.1KB +8.1KB
indexLifecycleManagement - 63.9KB +63.9KB
indexManagement - 43.8KB +43.8KB
infra - 172.3KB +172.3KB
ingestPipelines - 26.1KB +26.1KB
lens - 34.3KB +34.3KB
licenseManagement - 19.6KB +19.6KB
licensing - 14.8KB +14.8KB
lists - 142.7KB +142.7KB
logstash - 22.2KB +22.2KB
maps - 138.4KB +138.4KB
mapsFileUpload - 7.2KB +7.2KB
mapsLegacyLicensing - 3.4KB +3.4KB
ml - 57.1KB +57.1KB
monitoring - 49.7KB +49.7KB
observability - 36.8KB +36.8KB
osquery - 9.8KB +9.8KB
painlessLab - 22.2KB +22.2KB
remoteClusters - 25.8KB +25.8KB
reporting - 95.9KB +95.9KB
rollup - 55.2KB +55.2KB
runtimeFields - 23.1KB +23.1KB
savedObjectsTagging - 36.0KB +36.0KB
searchprofiler - 45.7KB +45.7KB
security - 131.0KB +131.0KB
securitySolution - 224.4KB ⚠️ +224.4KB
snapshotRestore - 60.0KB +60.0KB
spaces - 231.3KB ⚠️ +231.3KB
stackAlerts - 18.8KB +18.8KB
transform - 23.5KB +23.5KB
triggersActionsUi - 143.8KB +143.8KB
uiActionsEnhanced - 226.3KB ⚠️ +226.3KB
upgradeAssistant - 33.4KB +33.4KB
uptime - 19.3KB +19.3KB
urlDrilldown - 42.1KB +42.1KB
watcher - 24.2KB +24.2KB
total ⚠️ +3.6MB
Unknown metric groups

async chunk count

id before after diff
apm - 11 +11
beatsManagement - 2 +2
canvas - 6 +6
crossClusterReplication - 1 +1
dataEnhanced - 2 +2
enterpriseSearch - 7 +7
fleet - 5 +5
graph - 1 +1
grokdebugger - 1 +1
indexLifecycleManagement - 1 +1
indexManagement - 1 +1
infra - 13 +13
ingestPipelines - 1 +1
lens - 1 +1
licenseManagement - 2 +2
logstash - 1 +1
maps - 1 +1
mapsFileUpload - 1 +1
ml - 20 +20
monitoring - 1 +1
observability - 3 +3
osquery - 1 +1
painlessLab - 1 +1
remoteClusters - 1 +1
reporting - 1 +1
rollup - 1 +1
savedObjectsTagging - 4 +4
searchprofiler - 1 +1
security - 18 +18
securitySolution - 23 +23
snapshotRestore - 1 +1
spaces - 1 +1
stackAlerts - 3 +3
transform - 1 +1
triggersActionsUi - 32 +32
upgradeAssistant - 1 +1
uptime - 10 +10
watcher - 2 +2
total +184

miscellaneous assets size

id before after diff
apm - 49.0KB +49.0KB
enterpriseSearch - 881.0KB ⚠️ +881.0KB
maps - 979.3KB ⚠️ +979.3KB
securitySolution - 326.0KB ⚠️ +326.0KB
triggersActionsUi - 37.7KB +37.7KB
total ⚠️ +2.2MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 4e94a58 into elastic:7.x Feb 4, 2021
@smith smith deleted the backport/7.x/pr-89793 branch February 4, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants