-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add warning severity to Metric Alerts #90070
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
…vels # Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx
…vels # Conflicts: # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 10 hosts reporting an average around 12-20%, then I have one host that is pushing 100% (which averages out to about 50% (ish). When I set the threshold to 50%
I would expect the preview to say something like
There were 60 instances that satisfied the conditions of this alert across 1 kubernetes.pod.uids in the last hour.
but instead it says
There were 60 instances that satisfied the conditions of this alert across 10 kubernetes.pod.uids in the last hour.
It feels like we are counting too many UUIDs for the match. When the alert runs, it only matches on one UUID.
@simianhacker That's unrelated to this PR, we can file an issue for that. It's currently the expected behavior (telling the user that the alert examined 10 pods total) but we can revisit the language again since it's ambiguous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Closes #88591
Closes #89912
Should also fix #89807
Screenshots are from the Metric Threshold alert type, but the Warning threshold is also available on the Inventory alert type. Test them both during PR review.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)