[Lens] Memoize editor frame #89865
Merged
[Lens] Memoize editor frame #89865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:Visualizations
flash1293
commented
Feb 1, 2021
| @@ -514,6 +522,12 @@ export function App({ | |||
| } | |||
| }; | |||
|
|
|||
| const lastKnownDocRef = useRef(state.lastKnownDoc); | |||
There was a problem hiding this comment.
Those are save to pass in via refs because they are only used in the onChange callback to compare
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
stratoula
approved these changes
Feb 4, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Feb 4, 2021
|
Just realised I pressed submit on merge already happened :D |
flash1293
added a commit
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memoizes editor frame rendering in Lens app. This avoid re-rendering the frame twice on every state change (because the
onChangehook in the app is called which is causing a subsequent re-render of the frame.Originally I planned to do this as part of #89690 but it's a quick win we can get in easily and IMHO the improvement is relevant enough to change it now
old:
new (note the missing "mount" block):
