Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove type dependency between index_management and fleet #89699

Merged
merged 2 commits into from
Feb 1, 2021
Merged

remove type dependency between index_management and fleet #89699

merged 2 commits into from
Feb 1, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jan 29, 2021 •
edited
Loading

Summary

This PR removes TS dependency on fleet plugin, which will unblock index_management migration to the TS project.

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 29, 2021
@mshustov mshustov marked this pull request as ready for review January 29, 2021 12:42
@mshustov mshustov requested a review from a team as a code owner January 29, 2021 12:42
This was referenced Jan 29, 2021
Merged
Closed
sebelga
sebelga approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this @restrry !

@mshustov
Copy link
Contributor Author

mshustov commented Feb 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 1.4MB 1.4MB +54.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 43.7KB 43.7KB +9.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 4380c49 into elastic:master Feb 1, 2021
@mshustov mshustov deleted the index-management-remove-type-dep-on-fleet branch February 1, 2021 18:32
@mshustov mshustov mentioned this pull request Feb 1, 2021
Merged
mshustov added a commit that referenced this pull request Feb 1, 2021
@mshustov @kibanamachine
remove type dependency between index_management and fleet (#89699) (#…
a7d8ade 
…89906)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshustov @kibanamachine @sebelga