Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts painlessLab to a TS project reference #89626

Merged

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jan 28, 2021

Summary

Partially addresses #89321

tsc compiler performance with running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit

** Before
Files:
Lines:

** After
Files: 16938
Lines: 1863297

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 28, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 28, 2021 22:16
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner January 28, 2021 22:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for helping us with this @TinaHeiligers !

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 98b8048 into elastic:master Jan 29, 2021
@TinaHeiligers TinaHeiligers deleted the ts-project-refs-es_ui/painless_lab branch January 29, 2021 16:47
TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants