chore(NA): introduce new yarn kbn reset command to support bazel workflow #89597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
This comment has been minimized.
This comment has been minimized.
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
…m:mistic/kibana into add-kbn-destroy-cmd-for-bazel-integration
tylersmalley
reviewed
Feb 2, 2021
tylersmalley
reviewed
Feb 2, 2021
…md-for-bazel-integration
…md-for-bazel-integration
This was referenced Feb 3, 2021
This comment has been minimized.
This comment has been minimized.
…m:mistic/kibana into add-kbn-destroy-cmd-for-bazel-integration
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
7.x/7.12: 1c6adb4 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Feb 3, 2021
…flow (elastic#89597) * chore(NA): introduce new yarn kbn destroy command to support bazel workflow * chore(NA): update wording for new kbn pm changes * chore(NA): update .bazelrc.common Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update .bazelrc Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/destroy.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/destroy.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): rename destroy command into reset * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): restore old behaviour on kbn clean * chore(NA): update reset command to delete bazel caches on disk * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update prefix to match bazel defined one for cache settings * chore(NA): update kbn pm dist file * chore(NA): update kbn pm dist * chore(NA): update gitignore * chore(NA): add new ignore files after changed bazel aggregated folder Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tylersmalley@me.com> # Conflicts: # packages/kbn-pm/dist/index.js
mistic
added a commit
that referenced
this pull request
Feb 4, 2021
…l workflow (#89597) (#90244) * chore(NA): introduce new yarn kbn reset command to support bazel workflow (#89597) * chore(NA): introduce new yarn kbn destroy command to support bazel workflow * chore(NA): update wording for new kbn pm changes * chore(NA): update .bazelrc.common Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update .bazelrc Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/destroy.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update packages/kbn-pm/src/commands/destroy.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): rename destroy command into reset * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): restore old behaviour on kbn clean * chore(NA): update reset command to delete bazel caches on disk * chore(NA): update packages/kbn-pm/src/commands/clean.ts Co-authored-by: Tyler Smalley <tylersmalley@me.com> * chore(NA): update prefix to match bazel defined one for cache settings * chore(NA): update kbn pm dist file * chore(NA): update kbn pm dist * chore(NA): update gitignore * chore(NA): add new ignore files after changed bazel aggregated folder Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tyler Smalley <tylersmalley@me.com> # Conflicts: # packages/kbn-pm/dist/index.js * chore(NA): update changes on kbm pm * chore(NA): fix jest test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
On Bazel we have two kind of cleans: a
softone and anharderone.When migrating into the Bazel new workflow we will have to manage the swaps between branches both using Bazel but also the swaps between Branches where one of them could not be using Bazel.
The new
yarn kbn resetshould be the way to go when switching from a non Bazel branch into a Bazel one and theyarn kbn cleanthe 99% of the time command to use when switching or working only with Bazel branches.