[Upgrade Assistant] Migrate server to new es-js client

[alisonelizabeth]

Part of #73973

This PR migrates Upgrade Assistant to use the new ES JS client.

How to test:

These changes are pretty widespread. I think UA has good test coverage to catch regressions, but it would also be good to run through the UI and do a quick smoke test.

1. Hack x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts and seed data:

      indices: indices.concat([
      {
        level: 'none',
        message: 'none level test',
        url: 'test/url',
        details: 'test details',
        index: 'test1',
        reindex: true,
        needsDefaultFields: false,
        blockerForReindexing: 'index-closed',
      },
      {
        level: 'info',
        message: 'info level test',
        url: 'test/url',
        details: 'test details',
        index: 'test2',
        reindex: true,
        needsDefaultFields: false,
      },
      {
        level: 'warning',
        message: 'warning level test2',
        url: 'test/url',
        details: 'test details',
        index: 'test3',
        reindex: true,
        needsDefaultFields: false,
      },
      {
        level: 'critical',
        message: 'metricbeat-1 successful fix',
        url: 'test/url',
        details: 'test details',
        index: 'metricbeat-1',
        reindex: false,
        needsDefaultFields: true,
      },
      {
        level: 'critical',
        message: 'metricbeat-2 failed fix',
        url: 'test/url',
        details: 'test details',
        index: 'metricbeat-2',
        reindex: false,
        needsDefaultFields: true,
      },
    ]),

Then, via Console, create indices:

PUT test1/_doc/1
{"foo":"bar"}
PUT test2/_doc/1
{"foo":"bar"}
PUT test3/_doc/1
{"foo":"bar"}
PUT metricbeat-1/_doc/1
{"foo":"bar"}

2. Navigate to Upgrade Assistant in Stack Management.
3. Verify enable/disable deprecation logging on the Overview tab
4. Go to the Indices tab and run reindex against test2 index

[alisonelizabeth]

I didn't realize these tests existed until today 😄 . We also have UA tests in x-pack/test/api_integration. In a future PR, it might be worth seeing if we can consolidate.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[jloleysens]

Great work @alisonelizabeth ! I tested locally and was able to re-index indices as before.

I did notice one issue unrelated to these changes that might be worth following up on:

Clicking this documentation link just sent me back to the stack management home screen. I'm not sure how this URL is generated and whether it is different in a prod environment, but just wanted to raise this for visibility.

[jloleysens]

I am guessing these values are no longer being maintained on the core server side since it is in a "legacy" directory so they are safe to duplicate here without risk of something changing and TS not catching it?

[alisonelizabeth]

Correct. I think it's safe to duplicate for now. I did not see any support for it with the new client. I also think UA was the only app consuming the legacy type.

[jloleysens]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 011345c

Metrics [docs]

✅ unchanged

History

• 💚 Build #101328 succeeded b7fb0bb
• 💚 Build #101173 succeeded 4657b0c
• 💚 Build #101154 succeeded b204850
• 💔 Build #101112 failed b70b7df
• 💔 Build #100842 failed bc92fa2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[alisonelizabeth]

Thanks for the review @jloleysens!

Clicking this documentation link just sent me back to the stack management home screen. I'm not sure how this URL is generated and whether it is different in a prod environment, but just wanted to raise this for visibility.

👍 The documentation URL is generated from the response from the deprecation info API. You can see in the mocked data above it appears as url: 'test/url', which is likely why it's redirecting you back.