Enable right click on visualizations and dashboards listings #88936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
|
@elasticmachine merge upstream |
stratoula
added
v8.0.0
v7.12.0
release_note:enhancement
Feature:Dashboard
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
sulemanof
suggested changes
Jan 26, 2021
There was a problem hiding this comment.
Hey @stratoula ! Thanks for the enhancement, this is great!
This just need couple of issues to be resolved:
- Navigating to different apps from Visualize app (e.x. Maps or Lens) causing a full page reload:
Screen.Recording.2021-01-26.at.13.00.49.mov
Wrapping the link component with RedirectAppLinksresolves the problem:
I'm not sure that Dashboard has the same problem since it doesn't have links to external apps, right?
- Other parameters from the global state are not persisted - filters, refresh interval, query.
That means all the state of pinned filters or refresh interval will be lost. Should be persisted in the url too.
src/plugins/visualize/public/application/utils/get_visualize_list_item_link.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
Thanx @sulemanof ❤️ I had totally missed the global state params. I think that it should be ok now |
|
@elasticmachine merge upstream |
sulemanof
approved these changes
Jan 27, 2021
ThomThomson
approved these changes
Jan 27, 2021
src/plugins/dashboard/public/application/listing/get_dashboard_list_item_link.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Jan 28, 2021
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jan 28, 2021
…#88936) * Enable right-click on visualizations listing page * Make it simpler * Enable right click to the dashboard listing * Add unit tests * Fix link on dashboard * Fix visualize link * Fix PR comments * Fix functional test failure * Use kbnUrlStateStorage instead * Change method to getDashboardListItemLink * Change method to getVisualizeListItemLink Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Jan 28, 2021
…#89558) * Enable right-click on visualizations listing page * Make it simpler * Enable right click to the dashboard listing * Add unit tests * Fix link on dashboard * Fix visualize link * Fix PR comments * Fix functional test failure * Use kbnUrlStateStorage instead * Change method to getDashboardListItemLink * Change method to getVisualizeListItemLink Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #88702. This PR enables the right click on the titles of the dashboards and visualizations listings.
EuiLinkhas been replaced with href. The function checks if the dashboards have the timerange saved. If not, it propagates the timeRange of the queryService to the URL. A unit test has been added.EuiLinkhas been replaced with href. The timeRange of the queryService is also propagated to the URL. A unit test has been added.Checklist
Delete any items that are not applicable to this PR.