removing kibana-core-ui from codeowners #88111
Conversation
myasonik
added
chore
v8.0.0
backport:skip
myasonik
added
the
release_note:skip
| /src/plugins/home/public @elastic/kibana-core | ||
| /src/plugins/home/server/*.ts @elastic/kibana-core | ||
| /src/plugins/home/server/services/ @elastic/kibana-core | ||
| /src/plugins/kibana_overview/ @elastic/kibana-core |
There was a problem hiding this comment.
I thought Kibana App owned this now, but I could be wrong?
There was a problem hiding this comment.
@timroes what do you think?
There was a problem hiding this comment.
Same here as below, we did never create or owned this, as it was created as part of the getting started experience, and from my understanding (and the wiki page) should be Design > Kibana Design. But I would say since this is the "analytics home" page not the general one, we could def argue if this should be owned by someone within the analytics area, in which case I feel/fear it will be Kibana App :D cc @timductive
| #CC# /src/plugins/home/public @elastic/kibana-core | ||
| #CC# /src/plugins/home/server/services/ @elastic/kibana-core | ||
| #CC# /src/plugins/home/ @elastic/kibana-core |
There was a problem hiding this comment.
Same as above, I thought Kibana App owned this now, but I could be wrong?
There was a problem hiding this comment.
@timroes what do you think?
There was a problem hiding this comment.
Nope we def gave away home and sample data to Core UI that time, not sure where it went from there, but Kibana App does not own that. My understanding from the Team organization wiki page is that Design > Kibana Design owns that currently? If that's not true, most likely we should also fix the wiki page :-)
There was a problem hiding this comment.
For both of these, the logic that originally moved them to Core UI still applies, I'd rather we left them on the Core team's responsibilities and created a hiring plan around it if there isn't bandwidth to cover them.
There was a problem hiding this comment.
It's uncomfortable to be pushing more onto either team (Core or App). However, the Core UI team is simply no more and the Kibana Design team has a very different set of objectives with even less engineering bandwith (almost none beyond the accessibility commitment).
As an aside, the main home page is also likely to evolve into something more complex based upon the Getting Started project. As the ingest management capabilities evolve, there is quite likely to more dynamic, user/space/role oriented content regarding managing data.
It's a tough spot, and we're here to support things that arise where we can. Hopefully, the load from these two areas (home and overview page) is very quiet in the meantime.
There was a problem hiding this comment.
I must have gotten this confused with the ownership transition of the Management app going to the Kibana App team. I'm fine with Core team owning this plugin. AFAIK there aren't any expected large changes to this UI other than possibly removing the feature catalog (since we now have navigational search).
There was a problem hiding this comment.
@ryankeairns - not a problem at all.
I think you're correct - we agreed that these areas would be owned by kibana-core going forward.
|
@elasticmachine merge upstream |
* master: (33 commits) [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311) [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420) Fix log msg (elastic#88370) [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600) removing kibana-core-ui from codeowners (elastic#88111) [Alerting] Migrate Event Log plugin to TS project references (elastic#81557) [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413) Porting fixes 1 (elastic#88477) [APM] Explicitly set environment for cross-service links (elastic#87481) chore(NA): remove mocha junit ci integrations (elastic#88129) [APM] Only display relevant sections for rum agent in service overview (elastic#88410) [Enterprise Search] Automatically mock shared logic files (elastic#88494) [APM] Disable Create custom link button on Transaction details page for read-only users [Docs] clean-up vega map reference documenation (elastic#88487) [Security Solution] Fix Timeline event details layout (elastic#88377) Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914) [Monitoring] Change cloud messaging on no data page (elastic#88375) [Uptime] clear ping state when PingList component in unmounted (elastic#88321) [APM] Consistent terminology for latency and throughput (elastic#88452) fix copy (elastic#88481) ...
Summary
Closing out #87190
With the kibana-core-ui team no longer really existing, moving codeownership over to kibana-core who seems to be the most logical team to take over. If y'all think other teams would be more appropriate for certain sections, happy to update.
CC @ryankeairns