Fix webhook errror messages to be more specific #87044

mikecote · 2020-12-30T14:20:22Z

In this PR, I'm improving the error message the Webhook connector gives when the execution fails. We should discuss whether this exposes too much about the error or just the right amount of information. I feel the previous behaviour is too limited when it comes to debugging.

Screenshots

Provides more details on some previous "unexpected error"

Previously it was only telling users error calling webhook, unexpected error and nothing else.

Provides more details when the response contains an error

Previously it would only have [400] Bad Request in the details section.

Shouldn't expose passwords (maybe username depending on the Webhook response) when authorization fails

Previously it would only have [401] Unauthorized in the details section.

gmmorris

LGTM

…ok-errors

elasticmachine · 2020-12-31T19:16:06Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

mikecote · 2021-01-04T12:50:54Z

@elasticmachine merge upstream

ymao1

LGTM!

mikecote · 2021-01-04T20:29:18Z

@kobelb @elastic/kibana-security I'm trying to find the right balance between exposing useful error messages and keeping the risk of exposing secrets low.

Right now the Webhook failures are very generic (mostly status code / generic error message) and we have to guess what may be wrong (certificates, proxy configuration, domain not found, bad request body, missing headers, etc). This causes SDHs where we can't easily support them unless we had more information in the error message.

The risk with the approach in my PR is that it relays error messages from a 3rd party services. If ever that service decides to include a secret (ex: password) in the response error message, we would relay that to the user. Though, if ever that was the case, it sounds like it would be something wrong on the 3rd party to not return such information?

kobelb · 2021-01-04T20:44:25Z

Though, if ever that was the case, it sounds like it would be something wrong on the 3rd party to not return such information?

I think that's a reasonable assumption.

legrego · 2021-01-04T20:52:36Z

Though, if ever that was the case, it sounds like it would be something wrong on the 3rd party to not return such information?

I think that's a reasonable assumption.

++ This feels ok to me as well. Thanks for checking!

* Initial work * Fix variables to pull from * Rename some variables Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

mikecote · 2021-01-05T13:17:18Z

@pmuellr I wonder if it would be worth doing something similar for email connector? To help with the SDHs.

kibanamachine · 2021-01-05T13:30:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7b7cb97
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/api_keys/home_page·ts.API Keys app Home page Loads the app

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:29:42]         └-: API Keys app
[00:29:42]           └-> "before all" hook
[00:29:42]           └-: Home page
[00:29:42]             └-> "before all" hook
[00:29:42]             └-> "before all" hook
[00:29:42]               │ debg set roles = kibana_admin
[00:29:42]               │ debg creating user test_user
[00:29:42]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] updated user [test_user]
[00:29:42]               │ debg created user test_user
[00:29:42]               │ debg TestSubjects.exists(kibanaChrome)
[00:29:42]               │ debg Find.existsByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=2500
[00:29:42]               │ debg TestSubjects.find(kibanaChrome)
[00:29:42]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=100000
[00:29:42]               │ debg browser[INFO] http://localhost:6111/app/logs/stream?sourceId=default&logPosition=(end:%272021-01-05T14:39:51.874Z%27,position:(tiebreaker:0,time:1609853991874),start:%272021-01-05T12:39:51.874Z%27,streamLive:!f)&logFilter=(expression:%27trace.id:433b4651687e18be2c6c8e3b11f53d09%27,kind:kuery) 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:42]               │
[00:29:42]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:43]               │ debg navigating to apiKeys url: http://localhost:6111/app/management/security/api_keys
[00:29:43]               │ debg navigate to: http://localhost:6111/app/management/security/api_keys
[00:29:44]               │ proc [kibana]  error  [14:09:36.048]  Error: Internal Server Error
[00:29:44]               │ proc [kibana]     at HapiResponseAdapter.toError (/dev/shm/workspace/kibana-build-xpack-1/src/core/server/http/router/response_adapter.js:132:19)
[00:29:44]               │ proc [kibana]     at HapiResponseAdapter.toHapiResponse (/dev/shm/workspace/kibana-build-xpack-1/src/core/server/http/router/response_adapter.js:86:19)
[00:29:44]               │ proc [kibana]     at HapiResponseAdapter.handle (/dev/shm/workspace/kibana-build-xpack-1/src/core/server/http/router/response_adapter.js:81:17)
[00:29:44]               │ proc [kibana]     at Router.handle (/dev/shm/workspace/kibana-build-xpack-1/src/core/server/http/router/router.js:164:34)
[00:29:44]               │ proc [kibana]     at runMicrotasks (<anonymous>)
[00:29:44]               │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:29:44]               │ proc [kibana]     at handler (/dev/shm/workspace/kibana-build-xpack-1/src/core/server/http/router/router.js:124:50)
[00:29:44]               │ proc [kibana]     at exports.Manager.execute (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
[00:29:44]               │ proc [kibana]     at Object.internals.handler (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@hapi/hapi/lib/handler.js:46:20)
[00:29:44]               │ proc [kibana]     at exports.execute (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@hapi/hapi/lib/handler.js:31:20)
[00:29:44]               │ proc [kibana]     at Request._lifecycle (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@hapi/hapi/lib/request.js:370:32)
[00:29:44]               │ proc [kibana]     at Request._execute (/dev/shm/workspace/kibana-build-xpack-1/node_modules/@hapi/hapi/lib/request.js:279:9)
[00:29:44]               │ERROR browser[SEVERE] http://localhost:6111/api/log_entries/entries - Failed to load resource: the server responded with a status of 500 (Internal Server Error)
[00:29:44]               │ERROR browser[SEVERE] http://localhost:6111/api/infra/log_source_configurations/default/status - Failed to load resource: the server responded with a status of 403 (Forbidden)
[00:29:44]               │ debg browser[INFO] http://localhost:6111/app/management/security/api_keys?_t=1609855775889 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:44]               │
[00:29:44]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:44]               │ debg ... sleep(700) start
[00:29:44]               │ debg ... sleep(700) end
[00:29:44]               │ debg returned from get, calling refresh
[00:29:45]               │ERROR browser[SEVERE] http://localhost:6111/39261/bundles/core/core.entry.js 12:194770 TypeError: Failed to fetch
[00:29:45]               │          at _callee3$ (http://localhost:6111/39261/bundles/core/core.entry.js:6:43987)
[00:29:45]               │          at l (http://localhost:6111/39261/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968491)
[00:29:45]               │          at Generator._invoke (http://localhost:6111/39261/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968244)
[00:29:45]               │          at Generator.forEach.e.<computed> [as throw] (http://localhost:6111/39261/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:321:968848)
[00:29:45]               │          at fetch_asyncGeneratorStep (http://localhost:6111/39261/bundles/core/core.entry.js:6:39045)
[00:29:45]               │          at _throw (http://localhost:6111/39261/bundles/core/core.entry.js:6:39453)
[00:29:45]               │ debg browser[INFO] http://localhost:6111/app/management/security/api_keys?_t=1609855775889 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:45]               │
[00:29:45]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:45]               │ debg currentUrl = http://localhost:6111/app/management/security/api_keys
[00:29:45]               │          appUrl = http://localhost:6111/app/management/security/api_keys
[00:29:45]               │ debg TestSubjects.find(kibanaChrome)
[00:29:45]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:29:45]               │ debg ... sleep(501) start
[00:29:46]               │ debg ... sleep(501) end
[00:29:46]               │ debg in navigateTo url = http://localhost:6111/app/management/security/api_keys
[00:29:46]               │ debg TestSubjects.exists(statusPageContainer)
[00:29:46]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:29:48]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:29:49]             └-> Hides management link if user is not authorized
[00:29:49]               └-> "before each" hook: global before each
[00:29:49]               │ debg TestSubjects.missingOrFail(apiKeys)
[00:29:49]               │ debg Find.waitForDeletedByCssSelector('[data-test-subj="apiKeys"]') with timeout=2500
[00:29:49]               └- ✓ pass  (516ms) "API Keys app Home page Hides management link if user is not authorized"
[00:29:49]             └-> Loads the app
[00:29:49]               └-> "before each" hook: global before each
[00:29:49]               │ debg set roles = test_api_keys
[00:29:49]               │ debg creating user test_user
[00:29:49]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] updated user [test_user]
[00:29:49]               │ debg created user test_user
[00:29:49]               │ debg TestSubjects.exists(kibanaChrome)
[00:29:49]               │ debg Find.existsByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=2500
[00:29:50]               │ debg TestSubjects.find(kibanaChrome)
[00:29:50]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=100000
[00:29:50]               │ debg browser[INFO] http://localhost:6111/app/management/security/api_keys?_t=1609855775889 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:50]               │
[00:29:50]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:51]               │ debg Checking for section header
[00:29:51]               │ debg TestSubjects.findAll(noApiKeysHeader)
[00:29:51]               │ debg Find.allByCssSelector('[data-test-subj="noApiKeysHeader"]') with timeout=10000
[00:30:01]               │ debg TestSubjects.getVisibleText(apiKeyAdminDescriptionCallOut)
[00:30:01]               │ debg TestSubjects.find(apiKeyAdminDescriptionCallOut)
[00:30:01]               │ debg Find.findByCssSelector('[data-test-subj="apiKeyAdminDescriptionCallOut"]') with timeout=10000
[00:30:01]               │ERROR browser[SEVERE] http://localhost:6111/internal/security/api_key/privileges - Failed to load resource: the server responded with a status of 400 (Bad Request)
[00:30:11]               │ info Taking screenshot "/dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/screenshots/failure/API Keys app Home page Loads the app.png"
[00:30:11]               │ info Current URL is: http://localhost:6111/app/management/security/api_keys
[00:30:11]               │ info Saving page source to: /dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/failure_debug/html/API Keys app Home page Loads the app.html
[00:30:11]               └- ✖ fail: API Keys app Home page Loads the app
[00:30:11]               │      TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="apiKeyAdminDescriptionCallOut"])
[00:30:11]               │ Wait timed out after 10012ms
[00:30:11]               │       at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:30:11]               │       at runMicrotasks (<anonymous>)
[00:30:11]               │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:30:11]               │ 
[00:30:11]               │

Stack Trace

TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="apiKeyAdminDescriptionCallOut"])
Wait timed out after 10012ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  remoteStacktrace: ''
}

X-Pack API Integration Tests (Security Basic).x-pack/test/api_integration/apis/security/api_keys·ts.security (basic license) API Keys GET /internal/security/api_key/_enabled should indicate that API Keys are enabled

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: security (basic license)
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: API Keys
[00:00:00]             └-> "before all" hook
[00:00:00]             └-: GET /internal/security/api_key/_enabled
[00:00:00]               └-> "before all" hook
[00:00:00]               └-> should indicate that API Keys are enabled
[00:00:00]                 └-> "before each" hook: global before each
[00:00:00]                 └- ✖ fail: security (basic license) API Keys GET /internal/security/api_key/_enabled should indicate that API Keys are enabled
[00:00:00]                 │      Error: expected 200 "OK", got 400 "Bad Request"
[00:00:00]                 │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:00:00]                 │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:00:00]                 │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:00:00]                 │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:00:00]                 │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:00:00]                 │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
[00:00:00]                 │       at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
[00:00:00]                 │       at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:00:00]                 │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:00:00]                 │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:00:00]                 │ 
[00:00:00]                 │

Stack Trace

Error: expected 200 "OK", got 400 "Bad Request"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

X-Pack EPM API Integration Tests.x-pack/test/fleet_api_integration/apis/agents/unenroll·ts.Fleet Endpoints fleet_unenroll_agent should allow to unenroll single agent

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Fleet Endpoints
[00:00:00]           └-> "before all" hook
[00:00:39]           └-: fleet_unenroll_agent
[00:00:39]             └-> "before all" hook
[00:00:39]             └-> "before all" hook
[00:00:39]               │ info [fleet/agents] Loading "mappings.json"
[00:00:39]               │ info [fleet/agents] Loading "data.json"
[00:00:39]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/tzTVDHBjQh26KFy8fCjWyA] deleting index
[00:00:39]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/o6fZ1h9wQtuQ8pZ1WaMkVg] deleting index
[00:00:39]               │ info [fleet/agents] Deleted existing index [".kibana_2",".kibana_1"]
[00:00:39]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:00:39]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:00:39]               │ info [fleet/agents] Created index ".kibana_1"
[00:00:39]               │ debg [fleet/agents] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/t-CszMozTbabH1h6pcxlkA] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/t-CszMozTbabH1h6pcxlkA] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/t-CszMozTbabH1h6pcxlkA] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/t-CszMozTbabH1h6pcxlkA] update_mapping [_doc]
[00:00:39]               │ info [fleet/agents] Indexed 13 docs into ".kibana"
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_1/t-CszMozTbabH1h6pcxlkA] update_mapping [_doc]
[00:00:39]               │ debg Migrating saved objects
[00:00:39]               │ proc [kibana]   log   [14:26:32.321] [info][savedobjects-service] Creating index .kibana_2.
[00:00:39]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:00:39]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:39]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_2][0]]"
[00:00:39]               │ proc [kibana]   log   [14:26:32.392] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:39]               │ proc [kibana]   log   [14:26:32.654] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:40]               │ proc [kibana]   log   [14:26:32.694] [info][savedobjects-service] Finished in 375ms.
[00:00:40]             └-> "before all" hook
[00:00:40]               │ proc [kibana]   log   [14:26:32.711] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:40]               │ proc [kibana]   log   [14:26:32.712] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:40]               │ info [docker:registry] 2021/01/05 14:26:32 source.ip: 172.17.0.1:42646, url.original: /search?package=endpoint&internal=true&experimental=true
[00:00:40]               │ info [docker:registry] 2021/01/05 14:26:32 source.ip: 172.17.0.1:42644, url.original: /search?package=system&internal=true&experimental=true
[00:00:40]               │ proc [kibana]   log   [14:26:32.732] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:40]               │ proc [kibana]   log   [14:26:32.734] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:40]               │ info [docker:registry] 2021/01/05 14:26:32 source.ip: 172.17.0.1:42652, url.original: /search?package=endpoint&internal=true&experimental=true
[00:00:40]               │ info [docker:registry] 2021/01/05 14:26:32 source.ip: 172.17.0.1:42654, url.original: /search?package=system&internal=true&experimental=true
[00:00:40]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:40]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:41]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:41]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:41]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] [.kibana_2/dUXbZ4kfR1enpUH3m78LtQ] update_mapping [_doc]
[00:00:45]               │ proc [kibana]   log   [14:26:38.523] [info][fleet][plugins] Found previous transform references:
[00:00:45]               │ proc [kibana]  []
[00:00:45]               │ proc [kibana]   log   [14:26:38.524] [info][fleet][plugins] Deleting currently installed transform ids 
[00:00:45]               │ proc [kibana]   log   [14:26:38.539] [info][fleet][plugins] Found previous transform references:
[00:00:45]               │ proc [kibana]  []
[00:00:45]               │ proc [kibana]   log   [14:26:38.539] [info][fleet][plugins] Deleting currently installed transform ids 
[00:00:46]               │ proc [kibana]   log   [14:26:39.509] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:46]               │ proc [kibana]   log   [14:26:39.510] [info][fleet][plugins] Custom registry url is an experimental feature and is unsupported.
[00:00:46]               │ info [docker:registry] 2021/01/05 14:26:39 source.ip: 172.17.0.1:42994, url.original: /search?package=endpoint&internal=true&experimental=true
[00:00:46]               │ info [docker:registry] 2021/01/05 14:26:39 source.ip: 172.17.0.1:42996, url.original: /search?package=system&internal=true&experimental=true
[00:00:46]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] updated role [fleet_enroll]
[00:00:47]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1609852071981200825] updated user [fleet_enroll]
[00:00:49]             └-> should allow to unenroll single agent
[00:00:49]               └-> "before each" hook: global before each
[00:00:49]               └-> "before each" hook: beforeSetupWithDockerRegistry
[00:00:49]               └-> "before each" hook
[00:00:51]               │ proc [kibana]   log   [14:26:44.250] [error][api-key][authentication][plugins][security] Failed to invalidate API key as current user: x_content_parse_exception
[00:00:51]               │ proc [kibana]   log   [14:26:44.250] [error][fleet][plugins] ResponseError: x_content_parse_exception
[00:00:51]               │ proc [kibana]     at onBody (/dev/shm/workspace/kibana-build-xpack-16/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:00:51]               │ proc [kibana]     at IncomingMessage.onEnd (/dev/shm/workspace/kibana-build-xpack-16/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:00:51]               │ proc [kibana]     at IncomingMessage.emit (events.js:327:22)
[00:00:51]               │ proc [kibana]     at endReadableNT (internal/streams/readable.js:1327:12)
[00:00:51]               │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:80:21) {
[00:00:51]               │ proc [kibana]   meta: {
[00:00:51]               │ proc [kibana]     body: { error: [Object], status: 400 },
[00:00:51]               │ proc [kibana]     statusCode: 400,
[00:00:51]               │ proc [kibana]     headers: {
[00:00:51]               │ proc [kibana]       'x-opaque-id': '3b0510d0-05c6-488f-bec7-9cbdf5d341b5',
[00:00:51]               │ proc [kibana]       'content-type': 'application/json; charset=UTF-8',
[00:00:51]               │ proc [kibana]       'content-length': '265'
[00:00:51]               │ proc [kibana]     },
[00:00:51]               │ proc [kibana]     meta: {
[00:00:51]               │ proc [kibana]       context: null,
[00:00:51]               │ proc [kibana]       request: [Object],
[00:00:51]               │ proc [kibana]       name: 'elasticsearch-js',
[00:00:51]               │ proc [kibana]       connection: [Object],
[00:00:51]               │ proc [kibana]       attempts: 0,
[00:00:51]               │ proc [kibana]       aborted: false
[00:00:51]               │ proc [kibana]     }
[00:00:51]               │ proc [kibana]   }
[00:00:51]               │ proc [kibana] }
[00:00:51]               │ proc [kibana]   log   [14:26:44.255] [error][api-key][authentication][plugins][security] Failed to invalidate API key as current user: x_content_parse_exception
[00:00:51]               └- ✖ fail: Fleet Endpoints fleet_unenroll_agent should allow to unenroll single agent
[00:00:51]               │      Error: expected 200 "OK", got 500 "Internal Server Error"
[00:00:51]               │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:00:51]               │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:00:51]               │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:00:51]               │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:00:51]               │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:00:51]               │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
[00:00:51]               │       at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
[00:00:51]               │       at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:00:51]               │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:00:51]               │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:00:51]               │ 
[00:00:51]               │

Stack Trace

Error: expected 200 "OK", got 500 "Internal Server Error"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

and 3 more failures, only showing the first 3.

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	47264	48024	+760

History

💚 Build #96610 succeeded 7b7cb97
💚 Build #96499 succeeded b841d41
💚 Build #96421 succeeded bbdea96
💔 Build #96415 failed 554fe98

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Initial work * Fix variables to pull from * Rename some variables Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Initial work

554fe98

mikecote added release_note:enhancement v8.0.0 Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 labels Dec 30, 2020

mikecote self-assigned this Dec 30, 2020

mikecote added 2 commits December 30, 2020 09:57

Fix variables to pull from

3f5a53a

Rename some variables

bbdea96

gmmorris approved these changes Dec 30, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into improve-webho…

b841d41

…ok-errors

mikecote marked this pull request as ready for review December 31, 2020 19:16

mikecote requested a review from a team as a code owner December 31, 2020 19:16

Merge branch 'master' into improve-webhook-errors

7b7cb97

ymao1 approved these changes Jan 4, 2021

View reviewed changes

mikecote merged commit 875fde5 into elastic:master Jan 5, 2021

mikecote added v7.11.0 release_note:fix and removed release_note:enhancement labels Jan 5, 2021

mikecote changed the title ~~Improve webhook errror messages~~ Fix webhook errror messages to be more specific Jan 5, 2021

mikecote added a commit to mikecote/kibana that referenced this pull request Jan 5, 2021

Improve webhook errror messages (elastic#87044)

d6b18c6

* Initial work * Fix variables to pull from * Rename some variables Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

This was referenced Jan 5, 2021

[7.x] Improve webhook errror messages (#87044) #87297

Merged

[7.11] Improve webhook errror messages (#87044) #87299

Merged

mikecote added a commit to mikecote/kibana that referenced this pull request Jan 5, 2021

Improve webhook errror messages (elastic#87044)

0dc13ac

* Initial work * Fix variables to pull from * Rename some variables Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix webhook errror messages to be more specific #87044

Fix webhook errror messages to be more specific #87044

mikecote commented Dec 30, 2020 •

edited

Loading

gmmorris left a comment

elasticmachine commented Dec 31, 2020

mikecote commented Jan 4, 2021

ymao1 left a comment

mikecote commented Jan 4, 2021

kobelb commented Jan 4, 2021

legrego commented Jan 4, 2021

mikecote commented Jan 5, 2021

kibanamachine commented Jan 5, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Fix webhook errror messages to be more specific #87044

Fix webhook errror messages to be more specific #87044

Conversation

mikecote commented Dec 30, 2020 • edited Loading

Screenshots

Provides more details on some previous "unexpected error"

Provides more details when the response contains an error

Shouldn't expose passwords (maybe username depending on the Webhook response) when authorization fails

gmmorris left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 31, 2020

mikecote commented Jan 4, 2021

ymao1 left a comment

Choose a reason for hiding this comment

mikecote commented Jan 4, 2021

kobelb commented Jan 4, 2021

legrego commented Jan 4, 2021

mikecote commented Jan 5, 2021

kibanamachine commented Jan 5, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Distributable file count

History

mikecote commented Dec 30, 2020 •

edited

Loading

kibanamachine commented Jan 5, 2021 •

edited

Loading