Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Migrate grunt license:csv_report to script #86001

Merged
merged 6 commits into from
Jan 13, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 15, 2020

Part of a larger effort to remove our grunt depedencies, #85341.

  • This will need upstream changes to the release-manager, so we'll have to sync merges
  • Testing can be done by checking out f4357c0 and comparing the outputs of the grunt task with the script:
npx grunt licenses:csv_report --csv=$HOME/dev/kibana/foo1.csv  
node scripts/licenses_csv_report.js --csv=$HOME/dev/kibana/foo2.csv

@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Dec 15, 2020
@jbudz jbudz requested a review from a team as a code owner December 15, 2020 18:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented Dec 15, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

The release manager references the grunt task - so we will want to maybe first migrate the RM to reference the NPM script to ease the transition.

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Jan 12, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 74e408f into elastic:master Jan 13, 2021
@jbudz jbudz deleted the grunt/license-csv-report branch January 13, 2021 15:50
jbudz added a commit that referenced this pull request Jan 13, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz
Copy link
Member Author

jbudz commented Jan 13, 2021

7.x: f664621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants