Update painless autocomplete definitions #85464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
jloleysens
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
This is a fantastic change! Great job @alisonelizabeth .
Tested locally and confirmed that painless autocomplete still works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the painless autocomplete definitions.
Note: the script was run against ES
master; the generated context definitions in ES are currently the same inmasterand7.x, so it should not need to be run again against7.xfor this release.Related to elastic/elasticsearch#66050, elastic/elasticsearch#66120
Background
Each painless context has a set of shared classes that previously was represented in each context definition. This created large autocomplete definition files (~1MB) per context (more info around this here: #80577 (comment)). With the support of elastic/elasticsearch#66050, there is now a "common" file with common classes, and each context only contains the specialized classes associated with it. The UI code concats the common classes with context-specific classes to form the autocomplete suggestions list.
Other changes to note:
The generated definition files now exclude primitive types (e.g.,
boolean,int,char). We already have defined these values in the lexer_rules, so we grab the values from there to populate the autocomplete suggestions.How to test
I don't expect all classes and contexts to be tested 😄, but if you can do a quick smoke test of the autocomplete functionality that would be helpful. There is existing test coverage to verify the suggestions are still in the correct format.