Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new elasticsearch client for Visualizations #85245

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 8, 2020

Part of #83910

Summary

Switch to new elasticsearch client for Visualizations

@alexwizp alexwizp self-assigned this Dec 8, 2020
@alexwizp alexwizp added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 8, 2020
@alexwizp alexwizp marked this pull request as ready for review December 8, 2020 10:35
@alexwizp alexwizp requested a review from a team December 8, 2020 10:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@@ -121,7 +121,9 @@ const enlargedMockSavedObjects = [
describe('Visualizations usage collector', () => {
const mockIndex = '';
const getMockCallCluster = (hits: unknown[]) =>
(() => Promise.resolve({ hits: { hits } }) as unknown) as LegacyAPICaller;
(({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change it on

const getMockCallCluster = (hits: unknown[]) =>
    ({
      search: () => Promise.resolve({ body: { hits: { hits } } }) as unknown,
    } as ElasticsearchClient);

makes TS to complain?

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally in FF and works fine

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 46990 47750 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit b3d5dce into elastic:master Dec 10, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Dec 10, 2020
* Switch to new elasticsearch client for Visualizations

* update get_usage_collector.test.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 10, 2020
* master: (53 commits)
  Fixing recovered instance reference bug (elastic#85412)
  Switch to new elasticsearch client for Visualizations (elastic#85245)
  Switch to new elasticsearch client for TSVB (elastic#85275)
  Switch to new elasticsearch client for Vega (elastic#85280)
  [ILM] Add shrink field to hot phase (elastic#84087)
  Add rolling-file appender to core logging (elastic#84735)
  [APM] Service overview: Dependencies table (elastic#83416)
  [Uptime ]Update empty message for certs list (elastic#78575)
  [Graph] Fix graph saved object references (elastic#85295)
  [APM] Create new API's to return Latency and Throughput charts (elastic#85242)
  [Advanced settings] Reset to default for empty strings (elastic#85137)
  [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761)
  [Fleet] Update agent listing for better status reporting (elastic#84798)
  [APM] enable 'sanitize_field_names' for Go (elastic#85373)
  Update dependency @elastic/charts to v24.4.0 (elastic#85452)
  Introduce external url service (elastic#81234)
  Deprecate disabling the security plugin (elastic#85159)
  [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355)
  [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API
  chore: 🤖 remove extraPublicDirs (elastic#85454)
  ...
alexwizp added a commit that referenced this pull request Dec 10, 2020
* Switch to new elasticsearch client for Visualizations

* update get_usage_collector.test.ts
@alexwizp alexwizp deleted the es-client_vega branch January 16, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants