Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Metrics UI] Add metadata tab to node details flyout (#84454) #84971

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

phillipb
Copy link
Contributor

@phillipb phillipb commented Dec 3, 2020

Backports the following commits to 7.x:

* Add properties tab to flyout

* Better id for i18n title

* Update i18n ids

* Fix test and styling

* Style changes, add support for collapsing array fields

* Add loading indicators

* Fix type check

* Fix another test

* Fix tests for pods

* Add link to node details page

* Only show the overlay when viewing hosts

* Take into account cores when showing cpu

* Make it easier to read

* Remove unnecessary cast

* Fix PR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@phillipb
Copy link
Contributor Author

phillipb commented Dec 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1054 1082 +28

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.6MB 2.7MB +104.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit 16b0b9b into elastic:7.x Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants