Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate painless autocomplete in runtime fields editor #84943

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Dec 3, 2020

This PR integrates painless autocompletion in the runtime fields editor.

Continuation of #80577.

How to test

Verify autocomplete functionality is working in the runtime field editor. The runtime field editor is currently only integrated in the composable index template, legacy index template, and component template wizards.

For a list of available autocomplete functionality, check out the "Testing" section in #80577.

In order to test field autocompletion, you need to create at least one mapped field.

Known issues

I've received some feedback already around improvements that can be made to the autocomplete. I will handle these in a separate PR (#85055):

  • Auto closing brackets
  • Autocomplete support for emit() and params
  • Filter out text field types from the field autocomplete suggestions; text field types are never in doc values.
  • Autocomplete should not kick in for string and boolean values

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Mappings Editor Index mappings editor UI v7.11.0 Project:RuntimeFields labels Dec 3, 2020
@alisonelizabeth alisonelizabeth marked this pull request as ready for review December 4, 2020 14:50
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner December 4, 2020 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth changed the title Integrate painless autocomplete in runtime editor Integrate painless autocomplete in runtime fields editor Dec 4, 2020
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 1.5MB 1.5MB +32.0B

Distributable file count

id before after diff
default 46921 47681 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
runtimeFields 29.8KB 30.9KB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alisonelizabeth , great job on adding autocomplete to runtime fields editor! I tested locally and all worked for me, changes in code LGTM too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Mappings Editor Index mappings editor UI Project:RuntimeFields release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants