Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): upgrade node-sass into v4.14.1 to stop shipping old node-gyp #84935

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 3, 2020

Looks like after #83425 @peteharverson was not being able to bootstrap on windows. I was suspecting the problem was caused by some old node-gyp version installed and @marius-dr found the version of node-sass we were using ships with an old version of it. That PR intends to solve the mentioned issue by upgrading node-sass to its latest version which ships with a newer node-gyp version.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 3, 2020
@mistic mistic self-assigned this Dec 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It was at least easier than the Node 12 transition

@LeeDr LeeDr mentioned this pull request Dec 3, 2020
1 task
@mistic mistic requested a review from a team as a code owner December 3, 2020 19:35
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic changed the title chore(NA): upgrade node-sass into last v4.14.1 to stop shipping old n… chore(NA): upgrade node-sass into last v5.0.0 to stop shipping old node-gyp Dec 3, 2020
@kindsun kindsun self-requested a review December 3, 2020 20:06
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having the same issue on Ubuntu 20.04.1 LTS. Confirmed this fix worked in this environment. lgtm w/ green CI!

@mistic mistic requested a review from a team as a code owner December 3, 2020 20:18
@mistic mistic changed the title chore(NA): upgrade node-sass into last v5.0.0 to stop shipping old node-gyp chore(NA): upgrade node-sass into v4.14.1 to stop shipping old node-gyp Dec 3, 2020
@mistic
Copy link
Member Author

mistic commented Dec 3, 2020

I was trying to upgrade directly into node-sass@5.0.0 but the changes were throwing a couple of failures that I don't want to deal with at the moment as it is not worth it. I've reverted the changes to upgrade into node-sass@4.14.1 instead which is reported to also be working under node v14

@mistic
Copy link
Member Author

mistic commented Dec 3, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Dec 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@mistic mistic merged commit a6bd1aa into elastic:master Dec 4, 2020
@mistic
Copy link
Member Author

mistic commented Dec 4, 2020

7.x: d17299e

mistic added a commit to mistic/kibana that referenced this pull request Dec 4, 2020
…ode-gyp (elastic#84935)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 4, 2020
…fields

* 'master' of github.com:elastic/kibana:
  [ILM] Fix delete phase serialization bug (elastic#84870)
  chore(NA): removes auto install of pre-commit hook (elastic#83566)
  chore(NA): upgrade node-sass into last v4.14.1 to stop shipping old node-gyp (elastic#84935)
  [Alerting] Enables AlertTypes to define the custom recovery action groups (elastic#84408)
  [ML] Functional tests - add missing test data cleanup (elastic#84998)
  Migrate privilege/role/user-related operations to a new Elasticsearch client. (elastic#84641)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer_and_serializer.test.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts
mistic added a commit that referenced this pull request Dec 4, 2020
…ode-gyp (#84935) (#85024)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants