chore(NA): check git version on pre-commit hook install #84811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-on-precommit-hook-install
…-on-precommit-hook-install
…-on-precommit-hook-install
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
reviewed
Dec 2, 2020
spalger
reviewed
Dec 2, 2020
spalger
reviewed
Dec 2, 2020
jbudz
approved these changes
Dec 2, 2020
tylersmalley
approved these changes
Dec 2, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
7.x: 9fc5982 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Dec 4, 2020
* chore(NA): checks installed git version when installing pre-commit hook * chore(NA): throw an error instead of log a warning * chore(NA): use createFailError instead * fix(NA): apply feedback from pr review for isCorrectGitVersionInstalled Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Dec 4, 2020
) * chore(NA): checks installed git version when installing pre-commit hook * chore(NA): throw an error instead of log a warning * chore(NA): use createFailError instead * fix(NA): apply feedback from pr review for isCorrectGitVersionInstalled Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps handling an issue described on #47214 (comment)
That PR looks for the current
gitversion installed and skips the pre-commit hook installation in case it is not greater or equal than2.5.