Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI][Metrics UI] Tweak navigation bar size for infra apps #84498

Merged
merged 2 commits into from
Dec 9, 2020
Merged

[Logs UI][Metrics UI] Tweak navigation bar size for infra apps #84498

merged 2 commits into from
Dec 9, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Nov 30, 2020

Summary

Part of #82823.

Tweaks the height of the navigation bar for the infra apps, giving more space for the content and aligning with the height of other apps (like security).

Before (left) and after (right)
Screenshot 2020-11-30 at 13 35 52

@afgomez afgomez added Feature:Metrics UI Metrics UI feature v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Nov 30, 2020
@afgomez afgomez added this to the Logs UI 7.11 milestone Nov 30, 2020
@afgomez afgomez requested a review from a team as a code owner November 30, 2020 12:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez added the release_note:skip Skip the PR/issue when compiling release notes label Nov 30, 2020
@afgomez afgomez mentioned this pull request Nov 30, 2020
Closed
2 tasks
@afgomez
Copy link
Contributor Author

afgomez commented Dec 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB -72.0B

Distributable file count

id before after diff
default 46981 47741 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit fb6a711 into elastic:master Dec 9, 2020
@afgomez afgomez deleted the 82823-infra-header-reduction branch December 9, 2020 14:27
afgomez pushed a commit to afgomez/kibana that referenced this pull request Dec 9, 2020
@kibanamachine
[Logs UI][Metrics UI] Tweak navigation bar size for infra apps (elast…
ad67c2e 
…ic#84498)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@afgomez afgomez mentioned this pull request Dec 9, 2020
Merged
afgomez pushed a commit that referenced this pull request Dec 9, 2020
@kibanamachine
[7.x] [Logs UI][Metrics UI] Tweak navigation bar size for infra apps (#…
9423d35 
…84498) (#85418)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@katrin-freihofner katrin-freihofner katrin-freihofner approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.11
Development

Successfully merging this pull request may close these issues.
5 participants
@afgomez @elasticmachine @kibanamachine @weltenwort @katrin-freihofner