Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase stdout max listeners for legacy logging #84497

Merged
merged 2 commits into from
Nov 30, 2020
Merged

increase stdout max listeners for legacy logging #84497

merged 2 commits into from
Nov 30, 2020

Conversation

pgayvallet
Copy link
Contributor

Summary

Increase the max listener count for stdout to avoid the

node:77321) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 26 finish listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
server   error  [13:32:17.435] [warning][process] MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 26 finish listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit
    at _addListener (events.js:389:17)
    at WriteStream.addListener (events.js:405:10)
    at WriteStream.Readable.on (_stream_readable.js:874:35)
    at WriteStream.once (events.js:436:8)
    at KbnLoggerStringFormat.Readable.pipe (_stream_readable.js:772:8)

errors

@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 30, 2020
@pgayvallet pgayvallet requested a review from a team November 30, 2020 12:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/CODEOWNERS
Comment on lines +190 to +192
/packages/kbn-config/ @elastic/kibana-core
/packages/kbn-logging/ @elastic/kibana-core
/packages/kbn-legacy-logging/ @elastic/kibana-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind these changes when backporting

@pgayvallet pgayvallet merged commit b99abe3 into elastic:master Nov 30, 2020
@pgayvallet pgayvallet mentioned this pull request Nov 30, 2020
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Nov 30, 2020
@pgayvallet
increase stdout max listeners for legacy logging (elastic#84497)
7132c3e 
* increase stdout max listeners for legacy logging

* add missing packages to CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
@mistic mistic mentioned this pull request Nov 30, 2020
Closed
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
@phillipb
Merge branch 'add-metadata-to-node-details' of github.com:phillipb/ki…
6a491e8 
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
pgayvallet added a commit that referenced this pull request Nov 30, 2020
@pgayvallet
increase stdout max listeners for legacy logging (#84497) (#84514)
8e1fe69 
* increase stdout max listeners for legacy logging

* add missing packages to CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
e066f65 
* master: (25 commits)
  [Alerting] fixes buggy default message behaviour (elastic#84202)
  [Graph] Use new ES client and change license API (elastic#84398)
  [DOCS] Adds redirect to known plugins page (elastic#84001)
  Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376)
  Adding timestamps to created events so the sorting is stable (elastic#84515)
  [DOCS] Redirects for drilldown links (elastic#83846)
  [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805)
  [Enterprise Search] Migrate shared Schema components (elastic#84381)
  [Discover] Unskip date_nanos and shard links functional tests (elastic#82878)
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @elasticmachine @kibanamachine @afharo