-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/optimizer/node] properly separate lmdb databases, log better #83849
Conversation
f2dec41
to
4e2c999
Compare
This reverts commit 45d3861.
4e2c999
to
dfcf25b
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small note: if there is any change the source maps we store in the smaps
db could have buffers I think we will need to use https://www.npmjs.com/package/buffer-json
The source map objects are really simple and designed to be sent over the network to the browsers so they just have string/string[] properties and are relatively compact. Nothing to worry about: |
…astic#83849) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…er (#83849) (#83941) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
The current lmdb-store implementation expects that lmdb-store won't throw an error when writing, and provides very little visibility into the operations of the cache. This updates the cache to write to a log file and write errors to stderr when things go wrong. Additionally, this switches the way that we're defining the sub-databases so that the argument structure we pass to lmdb-store is understood correctly. I'll work on a PR to lmdb-store once I'm done working on this.