[kbn/optimizer/node] properly separate lmdb databases, log better #83849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/lmdb-store-db-separation
branch
from
f2dec41
to
4e2c999
Compare
This reverts commit 45d3861.
spalger
force-pushed
the
fix/lmdb-store-db-separation
branch
from
4e2c999
to
dfcf25b
Compare
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mistic
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
LGTM, just a small note: if there is any change the source maps we store in the smaps db could have buffers I think we will need to use https://www.npmjs.com/package/buffer-json
The source map objects are really simple and designed to be sent over the network to the browsers so they just have string/string[] properties and are relatively compact. Nothing to worry about: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Nov 20, 2020
…astic#83849) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Nov 20, 2020
…er (#83849) (#83941) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current lmdb-store implementation expects that lmdb-store won't throw an error when writing, and provides very little visibility into the operations of the cache. This updates the cache to write to a log file and write errors to stderr when things go wrong. Additionally, this switches the way that we're defining the sub-databases so that the argument structure we pass to lmdb-store is understood correctly. I'll work on a PR to lmdb-store once I'm done working on this.