Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm] upgrade eslint-plugin-react-hooks #83674

Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 18, 2020

Upgrades eslint-plugin-react-hooks to get improvements for optional-chaining.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏 👍

this will address the problem I encountered here https://github.com/elastic/kibana/pull/83634/checks?check_run_id=1419457291

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 18, 2020

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Nov 18, 2020

Turns out this was handled by #83520

@spalger spalger closed this Nov 18, 2020
@spalger spalger deleted the upgrade/eslint-plugin-react-hooks branch November 18, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants