Transaction type handling and breakdown chart #83587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smith
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
Closed
|
retest |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
sorenlouv
reviewed
Nov 23, 2020
| @@ -23,7 +23,7 @@ import { ServiceMap } from '../ServiceMap'; | |||
| import { ServiceMetrics } from '../service_metrics'; | |||
| import { ServiceNodeOverview } from '../ServiceNodeOverview'; | |||
| import { ServiceOverview } from '../service_overview'; | |||
| import { TransactionOverview } from '../TransactionOverview'; | |||
| import { TransactionOverview } from '../transaction_overview'; | |||
There was a problem hiding this comment.
I'd love if there was a way to automatically rename all our files once and for all.
There was a problem hiding this comment.
maybe we could create a new issue to tackle all the renaming once and for all...
|
👷🏻♂️ 🚧 Fixing merging conflicts!!!! |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
sorenlouv
pushed a commit
to sorenlouv/kibana
that referenced
this pull request
Nov 24, 2020
sorenlouv
added a commit
that referenced
this pull request
Nov 24, 2020
|
tests ok |
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
useTransactionTypehook to select the correct transaction type.Does not change the errors chart or table to use transaction type.
Does not change the breakdown to use duration instead of percent.
References #81719. References #82831. Fixes #78969.