Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Converting legend key to optional #83495

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes https://github.com/elastic/sdh-kibana/issues/970 by making the legend key optional on the waffle map options state

@simianhacker simianhacker added release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Nov 16, 2020
@simianhacker simianhacker marked this pull request as ready for review November 16, 2020 22:47
@simianhacker simianhacker requested a review from a team as a code owner November 16, 2020 22:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.5MB 2.5MB +752.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit cc0d6c1 into elastic:master Nov 18, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Nov 18, 2020
* [Metrics UI] Converting legend key to optional

* Adding check and default to legend component
simianhacker added a commit to simianhacker/kibana that referenced this pull request Nov 18, 2020
* [Metrics UI] Converting legend key to optional

* Adding check and default to legend component
simianhacker added a commit that referenced this pull request Nov 18, 2020
* [Metrics UI] Converting legend key to optional

* Adding check and default to legend component
simianhacker added a commit that referenced this pull request Nov 18, 2020
* [Metrics UI] Converting legend key to optional

* Adding check and default to legend component
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
…o-node-details

* 'master' of github.com:elastic/kibana:
  SO Tagging: fix flaky test and re-enable it (elastic#82930)
  [Metrics UI] Converting legend key to optional (elastic#83495)
@simianhacker simianhacker deleted the optional-legend-fix branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants