[Ingest Manager] Lift up registry/{stream,extract} functions #83239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
added
release_note:skip
|
Are you sure about putting |
jfsiii
force-pushed
the
move-streams-functions-out-of-registry
branch
from
75a1e75
to
823b9b6
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Nov 12, 2020
…#83239) ## Summary * Move stream utility functions from `server/services/epm/registry/streams.ts` to `server/services/epm/streams.ts` * They're only used in registry at the moment but aren't specific to registry * Move archive extraction functions from `server/services/epm/registry/extract.ts` to `server/services/epm/archive.ts` * The Registry isn't the only service/code which needs to extract packages. Continue consolidating archive-related code under archive vs registry
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 12, 2020
* master:
[Ingest Manager] Lift up registry/{stream,extract} functions (elastic#83239)
[Reporting] Move "common" types and constants to allow cross-plugin integration (elastic#83198)
[Lens] Add suffix formatter (elastic#82852)
[App Search] Version documentation links (elastic#83245)
Use saved object references for dashboard drilldowns (elastic#82602)
Btsymbala/registered av (elastic#81910)
[APM] Errors table for service overview (elastic#83065)
jfsiii
pushed a commit
that referenced
this pull request
Nov 12, 2020
…#83305) ## Summary * Move stream utility functions from `server/services/epm/registry/streams.ts` to `server/services/epm/streams.ts` * They're only used in registry at the moment but aren't specific to registry * Move archive extraction functions from `server/services/epm/registry/extract.ts` to `server/services/epm/archive.ts` * The Registry isn't the only service/code which needs to extract packages. Continue consolidating archive-related code under archive vs registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
server/services/epm/registry/streams.tstoserver/services/epm/streams.tsserver/services/epm/registry/extract.tstoserver/services/epm/archive.ts