[ML] Additional job spaces initialization #83127

jgowdyelastic · 2020-11-10T22:21:56Z

Adds ability to allocate spaces for job when initialising existing jobs which do not have a saved object associated to them.
Normal behaviour is to put all existing jobs into the * space. However Logs jobs should be assigned to the space which exists in their job ID.

Adds an applyToAllSpaces override flag to the modules setup endpoint. This will place all jobs in the module into the * space.

Integrations

APM, Uptime and Security

module setup calls are passed the applyToAllSpaces flag so all jobs created will exist in the * space.
As long as the user pressing the button has permission to assign saved objects to the * space.

Logs

When creating ML jobs through the Logs UI, the jobs are created in whatever space is currently being used.
During initialisation, all existing jobs in the logs-ui group will be assigned to their correct space based on the job ID.
e.g. my_space space for kibana-logs-ui-my_space-default-log-entry-rate

Also fixes bug where an AD job and a DFA job cannot have the same ID.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-11-11T11:50:59Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/server/saved_objects/initialization/space_overrides.test.ts

elasticmachine · 2020-11-11T12:12:09Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2020-11-11T12:12:09Z

Pinging @elastic/uptime (Team:uptime)

smith

APM changes look good.

peteharverson

Tested initialization of ML jobs (not including logs UI jobs) and LGTM

alvarezmelissa87

LGTM 👍

jgowdyelastic · 2020-11-13T09:30:41Z

@elasticmachine merge upstream

jgowdyelastic · 2020-11-16T08:19:46Z

@elasticmachine merge upstream

shahzad31

LGTM uptime changes, we will discuss inside out team, if we also need to limit uptime anomaly jobs per space.

weltenwort

Tested successfully with jobs from the Logs UI. Thanks for taking care of them!

The Metrics UI also has an ML integration patterned after the one in the Logs UI. Their jobs might require the same treatment. Since I'm not familiar with the implementation differences, though, I'd like to defer to @phillipb for an opinion. 😇

weltenwort · 2020-11-16T14:16:34Z

x-pack/plugins/ml/server/saved_objects/initialization/initialization.ts

      const { initSavedObjects } = repairFactory(client, jobSavedObjectService);
-      const { jobs } = await initSavedObjects();
+      const { jobs } = await initSavedObjects(false, jobSpaceOverrides);
      mlLog.info(`${jobs.length} job saved objects initialized for * space`);


Nit: now that the space can be overridden per job this message might be misleading.

Updated in 663fa14

FrankHassanabad

Thanks for this on our side! Good to see all of this coming together.

phillipb · 2020-11-16T14:52:12Z

@weltenwort thanks for the heads up. From the looks of it, we would need basically the exact same treatment for job ids:

'k8s_memory_usage', 
'k8s_network_in',
'k8s_network_out',
'hosts_memory_usage',
'hosts_network_in',
'hosts_network_out',

@jgowdyelastic should that be apart of this PR?

jgowdyelastic · 2020-11-16T14:53:15Z

@weltenwort thanks for the heads up. From the looks of it, we would need basically the exact same treatment for job ids:
'k8s_memory_usage', 
'k8s_network_in',
'k8s_network_out',
'hosts_memory_usage',
'hosts_network_in',
'hosts_network_out',
@jgowdyelastic should that be apart of this PR?

Ok thanks @phillipb , yes i'll add these now.

jgowdyelastic · 2020-11-16T17:03:12Z

@phillipb metrics jobs added in 2ba8cf4

apmmachine · 2020-11-16T17:07:55Z

💚 Build Succeeded

pipeline
Commit: 2ba8cf4

rylnd

Security Solution changes LGTM 👍

kibanamachine · 2020-11-16T18:45:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2ba8cf4

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.9MB	7.9MB	+22.0B
`uptime`	982.9KB	983.0KB	+22.0B
total			+44.0B

Distributable file count

id	before	after	diff
`default`	42828	42834	+6

History

💚 Build #88011 succeeded 663fa14
💚 Build #87912 succeeded 056a4d1
💚 Build #87834 succeeded e66c84c
💚 Build #87571 succeeded 15e81ba
💚 Build #87330 succeeded 44f31c2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ML] Additional job spaces initialization * adding logs test * updating integrations * updating test text * fixing logs jobs error * fix bug with duplicate ids * updating initialization log text * fixing initialization text * adding metrics overrides Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

jgowdyelastic added 3 commits November 10, 2020 22:21

[ML] Additional job spaces initialization

ec31598

adding logs test

44cceb9

updating integrations

5ab3962

jgowdyelastic self-assigned this Nov 11, 2020

jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features release_note:enhancement review v7.11.0 v8.0.0 labels Nov 11, 2020

jgowdyelastic requested review from peteharverson and alvarezmelissa87 November 11, 2020 11:50

jgowdyelastic marked this pull request as ready for review November 11, 2020 11:50

jgowdyelastic requested review from a team and rylnd November 11, 2020 11:52

peteharverson reviewed Nov 11, 2020

View reviewed changes

x-pack/plugins/ml/server/saved_objects/initialization/space_overrides.test.ts Outdated Show resolved Hide resolved

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 11, 2020

updating test text

44f31c2

smith approved these changes Nov 11, 2020

View reviewed changes

fixing logs jobs error

4a80fdd

jgowdyelastic requested review from a team as code owners November 12, 2020 10:03

fix bug with duplicate ids

15e81ba

peteharverson approved these changes Nov 12, 2020

View reviewed changes

alvarezmelissa87 approved these changes Nov 12, 2020

View reviewed changes

Merge branch 'master' into additional-job-space-initialization

e66c84c

Merge branch 'master' into additional-job-space-initialization

056a4d1

shahzad31 approved these changes Nov 16, 2020

View reviewed changes

weltenwort self-requested a review November 16, 2020 11:47

weltenwort reviewed Nov 16, 2020

View reviewed changes

FrankHassanabad approved these changes Nov 16, 2020

View reviewed changes

jgowdyelastic added 2 commits November 16, 2020 14:34

updating initialization log text

dd59803

fixing initialization text

663fa14

adding metrics overrides

2ba8cf4

rylnd approved these changes Nov 16, 2020

View reviewed changes

jgowdyelastic mentioned this pull request Nov 16, 2020

[ML] [Meta] Spaces follow up tasks #82415

Closed

13 tasks

jgowdyelastic merged commit 6a1cd73 into elastic:master Nov 16, 2020

jgowdyelastic deleted the additional-job-space-initialization branch November 16, 2020 21:56

jgowdyelastic mentioned this pull request Nov 17, 2020

[7.x] [ML] Additional job spaces initialization (#83127) #83516

Merged

weltenwort mentioned this pull request Nov 18, 2020

[Logs UI] Migrate to the new space-aware ML APIs #67936

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Additional job spaces initialization #83127

[ML] Additional job spaces initialization #83127

jgowdyelastic commented Nov 10, 2020 •

edited

Loading

elasticmachine commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

smith left a comment

peteharverson left a comment

alvarezmelissa87 left a comment

jgowdyelastic commented Nov 13, 2020

jgowdyelastic commented Nov 16, 2020

shahzad31 left a comment

weltenwort left a comment

weltenwort Nov 16, 2020

jgowdyelastic Nov 16, 2020 •

edited

Loading

FrankHassanabad left a comment

phillipb commented Nov 16, 2020

jgowdyelastic commented Nov 16, 2020

jgowdyelastic commented Nov 16, 2020

apmmachine commented Nov 16, 2020

rylnd left a comment

kibanamachine commented Nov 16, 2020

[ML] Additional job spaces initialization #83127

[ML] Additional job spaces initialization #83127

Conversation

jgowdyelastic commented Nov 10, 2020 • edited Loading

Integrations

APM, Uptime and Security

Logs

elasticmachine commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

elasticmachine commented Nov 11, 2020

smith left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

jgowdyelastic commented Nov 13, 2020

jgowdyelastic commented Nov 16, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort Nov 16, 2020

Choose a reason for hiding this comment

jgowdyelastic Nov 16, 2020 • edited Loading

Choose a reason for hiding this comment

FrankHassanabad left a comment

Choose a reason for hiding this comment

phillipb commented Nov 16, 2020

jgowdyelastic commented Nov 16, 2020

jgowdyelastic commented Nov 16, 2020

apmmachine commented Nov 16, 2020

💚 Build Succeeded

rylnd left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 16, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Distributable file count

History

jgowdyelastic commented Nov 10, 2020 •

edited

Loading

jgowdyelastic Nov 16, 2020 •

edited

Loading