-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Disable exporting/importing of templates. Optimize pitch images a bit #83098
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
@ryankeairns or @MichaelMarcialis you all will probably want to take a look at the resulting pitch template to make sure the optimized images still look ok. Make sure you start up a fresh Elasticsearch instance to make sure you get the newest version of the template, |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* master: skip "Dashboards linked by a drilldown are both copied to a space" (elastic#83824) [alerts] adds action group and date to mustache template variables for actions (elastic#83195) skip flaky suite (elastic#79389) [DOCS] Reallocates limitations to point-of-use (elastic#79582) [Enterprise Search] Engine overview layout stub (elastic#83756) Disable exporting/importing of templates. Optimize pitch images a bit (elastic#83098) [DOCS] Consolidates plugins (elastic#83712) [ML] Space management UI (elastic#83320) test just part of the message to avoid updates (elastic#83703) [Data Table] Remove extra column in split mode (elastic#83193) Improve snapshot error messages (elastic#83785) skip flaky suite (elastic#83773) skip flaky suite (elastic#83771) skip flaky suite (elastic#65278) skip flaky suite (elastic#83793) [Task Manager] Ensures retries are inferred from the schedule of recurring tasks (elastic#83682) [index patterns] improve index pattern cache (elastic#83368) [Fleet] Rename ingestManager plugin ID fleet (elastic#83200) fixed pagination in connectors list (elastic#83638)
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
Fixes #81560
This disallows the exporting and importing of Canvas Workpad Template saved objects from Saved Object Management. We don't really have a reason for allowing these exports now, and if we decide there is a reason in the future we can readdress, but with installation from Fleet coming relatively soon, I'm not sure we will have a reason for that.
I also ran all of the images in the pitch_presentation template through some optimizers to reduce quality a bit, and it has significantly reduced the size of that template.