Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] offset option doesn't work properly for some values #83051

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 10, 2020

Closes: #40299

Summary

This PR is reverting #34283 because this PR brought us new issues with offset. Also I think date should be also parsed in UTC on server side to avoid this types of issues.

In my local offset works fine (second chart with 1y offset)
image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp requested a review from kobelb November 10, 2020 14:12
@alexwizp
Copy link
Contributor Author

alexwizp commented Nov 10, 2020

@kobelb could you please have a look that? I need your eyes to be sure that it will be finally fixed.

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am not sure if the previous bug still exists though. I tried to do some tests but couldn't reproduce it, and as this solves the problem with the offsets I approve it.

@alexwizp alexwizp marked this pull request as ready for review November 17, 2020 08:42
@alexwizp alexwizp requested a review from a team November 17, 2020 08:42
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp added Team:AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppArch labels Nov 17, 2020
@elastic elastic deleted a comment from elasticmachine Nov 17, 2020
@alexwizp alexwizp self-assigned this Nov 17, 2020
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp merged commit 93b0273 into elastic:master Nov 26, 2020
@alexwizp alexwizp changed the title TSVB offsets [TSVB] offset option doesn't work properly for some values Nov 26, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Nov 26, 2020
Closes: elastic#40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp added a commit that referenced this pull request Nov 26, 2020
Closes: #40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
* master:
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
  skip flaky suite (elastic#84440)
  skip flaky suite (elastic#84445)
  [APM] Fix missing `service.node.name` (elastic#84269)
  Upgrade fp-ts to 2.8.6 (elastic#83866)
  Added data streams privileges to better control delete actions in UI (elastic#83573)
  Improve short-url redirect validation (elastic#84366)
  TSVB offsets (elastic#83051)
  [Discover] Fix navigating back when changing index pattern (elastic#84061)
  [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139)
  [Logs UI] Limit the height of the "view in context" container (elastic#83178)
  [Application Usage] Update `schema` with new `fleet` rename (elastic#84327)
  fix identation in list (elastic#84301)
@alexwizp alexwizp deleted the #40299 branch January 16, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSVB offsets
3 participants