Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove data <--> expressions circular dependencies. (#82685) #83010

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

lukeelmers
Copy link
Member

Backports the following commits to 7.x:

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 585 588 +3
expressions 106 103 -3
kibanaUtils 190 191 +1
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaUtils 123.2KB 123.2KB +1.0B
lens 1.0MB 1.0MB +32.0B
securitySolution 7.8MB 7.8MB +731.0B
total +764.0B

Distributable file count

id before after diff
default 43117 43118 +1
oss 22747 22748 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 958.0KB 965.2KB +7.3KB
dataEnhanced 28.0KB 28.3KB +309.0B
expressions 188.9KB 181.6KB -7.4KB
kibanaUtils 148.0KB 150.2KB +2.3KB
securitySolution 243.3KB 243.6KB +238.0B
total +2.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit 7b0ce96 into elastic:7.x Nov 9, 2020
@lukeelmers lukeelmers deleted the backport/7.x/pr-82685 branch November 9, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants