Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yeoman & yo #82825

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Remove yeoman & yo #82825

merged 2 commits into from
Nov 6, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Nov 6, 2020

Summary

yeoman and yo were dependencies required to support KUI's component generator.
Since KUI is deprecated, we shouldn't be adding any new components, so the generator itself is not useful at this point.

As a result, this PR removes yeoman and yo from our list of dependencies, and removes the KUI Component Generator.

@legrego legrego added v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 6, 2020
@legrego legrego marked this pull request as ready for review November 6, 2020 13:59
@legrego legrego requested review from a team as code owners November 6, 2020 13:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 664.5KB 664.5KB -40.0B

page load bundle size

id before after diff
upgradeAssistant 74.5KB 74.5KB -40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley
Copy link
Contributor

Related to #82239

@legrego legrego merged commit 6b60599 into elastic:master Nov 6, 2020
@legrego legrego deleted the chore/remove-yo branch November 6, 2020 16:49
legrego added a commit that referenced this pull request Nov 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 9, 2020
* master: (68 commits)
  [Fleet] Make stream id unique in agent policy (elastic#82447)
  skip flaky suite (elastic#82915)
  skip flaky suite (elastic#75794)
  Copy `dateAsStringRt` to observability plugin (elastic#82839)
  [Maps] rename connected_components/map folder to mb_map (elastic#82897)
  [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619)
  [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546)
  Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056)
  [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090)
  Move single use function in line (elastic#82885)
  [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636)
  Add flot_chart dependency from shared_deps to Shareable Runtime (elastic#81649)
  [Security Solution][Detections] - Auto refresh all rules/monitoring tables (elastic#82062)
  [APM] Fix apm e2e runner script commands (elastic#82798)
  [Ingest Manager] Move cache functions to from registry to archive (elastic#82871)
  Update webpack-dev-server and webpack-cli (elastic#82844)
  [Uptime] Migrate to new es client (elastic#82003)
  Move parseAndVerify* functions to validation.ts (elastic#82845)
  Remove yeoman & yo (elastic#82825)
  [Canvas] Fix elements not being updated properly when filter is changed on workpad (elastic#81863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants