Provide method to render without sending .kibana/config #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think some light refactoring here could go a long way to making this easier to understand. I worry any time I see boolean arguments or compound conditions in ternary operators. Perhaps something like: https://gist.github.com/epixa/969ac59b277761feb9907bbfe0d13c34 Warning: that is completely untested |
| @@ -1,4 +1,5 @@ | |||
| # Kibana is served by a back end server. This setting specifies the port to use. | |||
| xpack.reporting.encryptionKey: foo | |||
There was a problem hiding this comment.
Probably didn't want this, can you amend it away?
jbudz
force-pushed
the
render-without-settings
branch
from
957b400 to
d4f2ee6
Compare
|
LGTM |
|
Wait, I take it back! |
|
|
||
| async function renderApp(app) { | ||
| const isElasticsearchPluginRed = server.plugins.elasticsearch.status.state === 'red'; | ||
| let payload = await getPayload(app); |
There was a problem hiding this comment.
This should be const since the reference itself is never changed.
jbudz
force-pushed
the
render-without-settings
branch
from
d4f2ee6 to
b680ba2
Compare
|
LGTM |
1 similar comment
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 9, 2016
--------- **Commit 1:** Provide method to render without sending .kibana/config * Original sha: 8fdcb83 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T19:05:07Z **Commit 2:** Provide explicit render methods for including and excluding settings * Original sha: b680ba2 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T20:41:11Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 9, 2016
--------- **Commit 1:** Provide method to render without sending .kibana/config * Original sha: 8fdcb83 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T19:05:07Z **Commit 2:** Provide explicit render methods for including and excluding settings * Original sha: b680ba2 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T20:41:11Z
This was referenced Sep 9, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Provide method to render without sending .kibana/config * Original sha: 8d2d0a492fa8f2fdcabf51f29a3cdf71bafdc2a3 [formerly 8fdcb83] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T19:05:07Z **Commit 2:** Provide explicit render methods for including and excluding settings * Original sha: a680d102e91905b634f6862b41652823730864e0 [formerly b680ba2] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-09T20:41:11Z Former-commit-id: 0c2dd87
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8207 to 5.x Former-commit-id: 6a404e7
tiansivive
added a commit
that referenced
this pull request
Jan 16, 2024
…isk Summary (#174574) Adding context in Risk Summary, part of [#8207](elastic/security-team#8207) Meta This PR handles both [#8357](elastic/security-team#8357) and [#8359](elastic/security-team#8359) <img width="609" alt="Screenshot 2024-01-10 at 12 06 00" src="https://github.com/elastic/kibana/assets/2423976/1f516eb9-1723-4c88-80b9-b61905a59f6a"> Closing #174443 since this PR includes those changes as well --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to render views using the chrome base template without passing user defined settings from .kibana/config.